Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332098

Summary: Metadata generator should not create mkdir/rmdir actions for reconciler bundle
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: p2Assignee: DJ Houghton <dj.houghton>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, pwebster
Version: 3.7   
Target Milestone: 3.6.2   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on:    
Bug Blocks: 332165    
Attachments:
Description Flags
patch none

Description DJ Houghton CLA 2010-12-07 18:43:22 EST 
In the old metadata generator code it is creating mkdir and rmdir configure/unconfigure actions for the reconciler bundle. 

We currently have clients who are still using the metadata generator (instead of the publisher) and this metadata will cause problems in shared installed scenarios. 

We should change the metadata generator code in R3.6.x to not do this. I'm sure not if we need to make the code change in HEAD since we plan on removing the generator soon. (in the 3.7 release I believe?)
Comment 1 DJ Houghton CLA 2010-12-08 11:35:12 EST 
Created attachment 184795 [details]
patch

Patch to remove the rmdir command from the unconfigure action for the reconciler bundle.
We've left the mkdir as-is.
Comment 2 John Arthorne CLA 2010-12-08 13:03:59 EST 
To give more background, in the metadata generator these actions were hard-coded as instructions on the p2.reconciler.dropins bundle. In the publisher, this hard-coding was removed entirely, and instead the mkdir action is done at the product level (whether dropins should exist, and where it should go, is a product-level concern). The rmdir action for dropins was removed entirely when we switched to the publisher.
Comment 3 DJ Houghton CLA 2010-12-08 14:27:55 EST 
Released to R36x branch.