Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332063

Summary: [Compatibility] Need to prevent NPE in IContextService's deactivateContext(IContextActivation) caused by null parameter
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3    
Version: 1.0   
Target Milestone: 4.1 M4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
ContextService patch v1 none

Description Remy Suen CLA 2010-12-07 13:00:54 EST 
Dunno how I missed this but I did. Bug 326406 is okay now but the line right after dies because we have an API method being called with a null parameter again.

java.lang.NullPointerException
at org.eclipse.ui.internal.contexts.ContextService.deactivateContext(ContextService.java:153)
at org.eclipse.debug.internal.ui.views.console.ProcessConsolePageParticipant.deactivated(ProcessConsolePageParticipant.java:255)
at org.eclipse.ui.internal.console.ConsoleView$8.run(ConsoleView.java:740)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.console.ConsoleView.deactivateParticipants(ConsoleView.java:738)
at org.eclipse.ui.internal.console.ConsoleView.showPageRec(ConsoleView.java:177)
at org.eclipse.ui.part.PageBookView.partActivated(PageBookView.java:759)
at org.eclipse.ui.internal.console.ConsoleView.display(ConsoleView.java:513)
at org.eclipse.debug.internal.ui.views.console.ProcessConsolePageParticipant.debugContextChanged(ProcessConsolePageParticipant.java:264)
at org.eclipse.debug.internal.ui.contexts.DebugWindowContextService$1.run(DebugWindowContextService.java:194)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.debug.internal.ui.contexts.DebugWindowContextService.notify(DebugWindowContextService.java:192)
at org.eclipse.debug.internal.ui.contexts.DebugWindowContextService.notify(DebugWindowContextService.java:173)
at org.eclipse.debug.internal.ui.contexts.DebugWindowContextService.debugContextChanged(DebugWindowContextService.java:390)
at org.eclipse.debug.ui.contexts.AbstractDebugContextProvider$1.run(AbstractDebugContextProvider.java:79)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.debug.ui.contexts.AbstractDebugContextProvider.fire(AbstractDebugContextProvider.java:77)
at org.eclipse.debug.internal.ui.views.launch.LaunchView$ContextProviderProxy.debugContextChanged(LaunchView.java:475)
at org.eclipse.debug.ui.contexts.AbstractDebugContextProvider$1.run(AbstractDebugContextProvider.java:79)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.debug.ui.contexts.AbstractDebugContextProvider.fire(AbstractDebugContextProvider.java:77)
at org.eclipse.debug.internal.ui.views.launch.LaunchView$TreeViewerContextProvider.activate(LaunchView.java:340)
at org.eclipse.debug.internal.ui.views.launch.LaunchView$1.selectionChanged(LaunchView.java:437)
at org.eclipse.jface.viewers.Viewer$2.run(Viewer.java:164)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:162)
at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2167)
at org.eclipse.jface.viewers.StructuredViewer.setSelection(StructuredViewer.java:1704)
at org.eclipse.jface.viewers.TreeViewer.setSelection(TreeViewer.java:1139)
at org.eclipse.debug.internal.ui.viewers.model.InternalTreeModelViewer.trySelection(InternalTreeModelViewer.java:1713)
at org.eclipse.debug.internal.ui.viewers.model.TreeModelContentProvider.handleSelect(TreeModelContentProvider.java:380)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateNodes(ModelContentProvider.java:1438)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateNodes(ModelContentProvider.java:1443)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateNodes(ModelContentProvider.java:1443)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateNodes(ModelContentProvider.java:1443)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateModel(ModelContentProvider.java:1390)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.doModelChanged(ModelContentProvider.java:1361)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.access$8(ModelContentProvider.java:1355)
at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider$14.runInUIThread(ModelContentProvider.java:1345)
at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
Comment 1 Remy Suen CLA 2010-12-07 13:01:26 EST 
Paul, I'll just add a null check for this tomorrow.
Comment 2 Paul Webster CLA 2010-12-07 13:06:59 EST 
(In reply to comment #1)
> Paul, I'll just add a null check for this tomorrow.

+1
PW
Comment 3 Remy Suen CLA 2010-12-08 07:59:37 EST 
Created attachment 184779 [details]
ContextService patch v1
Comment 4 Remy Suen CLA 2010-12-08 08:02:20 EST 
(In reply to comment #3)
> Created an attachment (id=184779) [details]
> ContextService patch v1

Patch delivered to CVS HEAD.
Comment 5 Remy Suen CLA 2010-12-09 08:03:37 EST 
Verified with I20101209-0255 on Windows XP.