Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332054

Summary: [prefs] Events fired for wrong node in EclipsePreferences
Product: [Eclipse Project] Equinox Reporter: Szymon Ptaszkiewicz <sptaszkiewicz>
Component: CompendiumAssignee: equinox.compendium-inbox <equinox.compendium-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dj.houghton, john.arthorne, Mike_Wilson, pwebster
Version: 3.6.1   
Target Milestone: 3.7 M7   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 207510    
Attachments:
Description Flags
Patch showing the expected behaviour Szymon.Brandys: iplog+

Description Szymon Ptaszkiewicz CLA 2010-12-07 12:08:57 EST
Created attachment 184734 [details]
Patch showing the expected behaviour

In org.eclipse.core.internal.preferences.EclipsePreferences.convertFromProperties(EclipsePreferences, Properties, boolean) listeners of wrong node are notified about new key-value pair being added. If we are calling childNode.internalPut(key, value) then we should be calling firePreferenceEvent for 'childNode' not for 'node'. Attached patch shows the expected behaviour.
Comment 1 DJ Houghton CLA 2011-03-24 17:17:57 EDT
Fixed in HEAD.