Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332037

Summary: Resolve warnings for Trace model validation
Product: z_Archived Reporter: Joel Cayne <jcayne>
Component: TPTPAssignee: Joel Cayne <jcayne>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: major    
Priority: P2 CC: ewchan, jgwest, jptoomey, paulslau
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for org.eclipse.tptp.platform.models
none
Patch for org.eclipse.tptp.platform.models.hierarchy none

Description Joel Cayne CLA 2010-12-07 10:57:44 EST 
This bug is a follow-up to bug 300671.

Complete the steps outlined in http://eclipse.org/tptp/platform/documents/resources/models/TPTP_Model_Generation.html#3.0 to setup and load the TPTP Trace model. When validating the trace.ecore, there are warnings displayed regarding proxy resolving. As a result of the warnings, the model cannot be generated as the editor will not open.

This bug is for implementing solution 2 in bug 300671 comment 6 to allow for model code generation.
Comment 1 Joel Cayne CLA 2010-12-07 11:15:55 EST 
Created attachment 184727 [details]
Patch for org.eclipse.tptp.platform.models

Updates the attributes and their opposites to not resolve proxies.

The attributes updated are those listed in bug 300671 comment 6:
TRCMethodInvocation.method (<-opposite-> TRCMethod.invocations)
TRCObject.isA (<-opposite-> TRCClass.objects)
TRCObjectReference.owner (<-opposite-> TRCHeapObject.refOwner)
TRCObjectReference.target (<-opposite-> TRCHeapObject.refTarget)
Comment 2 Joel Cayne CLA 2010-12-07 12:56:28 EST 
Created attachment 184742 [details]
Patch for org.eclipse.tptp.platform.models.hierarchy

Fix for a Class cast error reported in org.eclipse.tptp.platform.models.hierarchy.
Comment 3 Jonathan West CLA 2010-12-07 15:50:55 EST 
Patch looks good.
Comment 4 Joel Cayne CLA 2010-12-07 16:11:02 EST 
Thanks Jonathan!

I have tested with TPTP Profiling (Execution and Memory Analysis), TPTP JUnit and TPTP URL test. Comparing the output of a saved profiling Memory Analysis session there are no noticeable differences.

The patch for org.eclipse.tptp.platform.models has been checked into HEAD.

The patch for org.eclipse.tptp.platform.models.hierarchy is not checked in, as another workspace did not report the Class cast problem.
Comment 5 Joel Cayne CLA 2011-01-06 16:11:14 EST 
Resolving.
Comment 6 Joel Cayne CLA 2011-01-17 09:25:58 EST 
Closing.