Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331977

Summary:	Trailing space in URI causes connection problems and restart of Eclipse
Product:	[Technology] EGit	Reporter:	Johan Natt och Dag <johan>
Component:	Core	Assignee:	Mathias Kinzler <mathias.kinzler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	caniszczyk, johan, mathias.kinzler
Version:	0.9.0
Target Milestone:	0.11-M1
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Johan Natt och Dag

2010-12-07 01:40:27 EST

A URI that, for example, is copied from the web (e.g., from ProjectLocker) may include a trailing space.

This may causes the following:

a) If user has not tried to connect to the git server before, EGit keeps asking for password (not passphrase). A restart of Eclipse is REQUIRED before trying again (now without the trailing space in the URI).

b) If the user has connected to the site before, Egit replies with an error message "Arguments to command look dangerous". In this case restart is NOT required.

This problem causes lot of headache and it can be very hard for the end user to discover and find the correct resolution.

I suggest that EGit at least warns about trailing characters that do not belong in the URI. Often trimming is made to handle this, but a warning could suffice. However, that a restart is required may call for other measures.

Comment 1 Johan Natt och Dag

2010-12-07 01:42:00 EST

EGit version is actually 0.9.1, but it is not available in the drop-down list in Bugzilla.

Comment 2 Mathias Kinzler

2010-12-30 05:25:56 EST

Fix proposed at http://egit.eclipse.org/r/#change,2190

Comment 3 Chris Aniszczyk

2011-01-19 03:46:19 EST

Fixed with a6d127ae1a588186525dbaaba6f7388ea8cfa048.