Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331957

Summary: Latest NDK version -r5 has different path structure than previous.
Product: z_Archived Reporter: Mike Edenfield <kutulu>
Component: SequoyahAssignee: Project Inbox <android.sequoyah-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: benoit, cdtdoug, j-arenson, kpqb38, nkvg64, wmg040
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Adding support for both NDK r4 and r5
wmg040: iplog+
Adding support for ndk r4, r5 and r6 wmg040: iplog+

Description Mike Edenfield CLA 2010-12-06 16:35:05 EST
Build Identifier: M20100909-0800

The latest NDK version, -r5, uses a slightly different path layout than previous NDK builds.  The current Sequoyah plug-in does not recognize the root of this distribution as a valid NDK Location, and 

Previously the NDK tree looked like:

${NDK_ROOT}/build/prebuilt/${HOST}/${ABI}-${VER}

The new NDK tree looks like:

${NDK_ROOT}/toolchains/${ABI}-${VER}/prebuilt/${HOST}

In addition, the ABI for gcc-4.4.3 has been renamed from arm-eabi to arm-linux-androideabi.



Reproducible: Always

Steps to Reproduce:
1. Upgrade to NDK -r5
2. Open Preference > Android > Android NDK
3. Attempt to set NDK Location to root of -r5 NDK tree.
Comment 1 Carlos Alberto Souto Junior CLA 2010-12-14 10:58:45 EST
Created attachment 185146 [details]
Adding support for both NDK r4 and r5

This patch adds the new folder structure of the Android NDK r5 to the path validation scheme. It fixes the Preference page name as well.
Comment 2 Carlos Alberto Souto Junior CLA 2011-07-13 11:58:09 EDT
Created attachment 199606 [details]
Adding support for ndk r4, r5 and r6

This patch adds the validation case for the new arm-eabi folder structure present in the Android NDK r6, keeping backward compatibility with previous versions
Comment 3 Benoit Malrat CLA 2011-07-21 10:13:06 EDT
Hello,

It still have a bug in the allocation of pathPrefix.
As you can see you have sized the array with 2 and you want to put in 3 elements thats caussing a java crash.

regards
Comment 4 Marcel Gorri CLA 2011-07-21 15:12:15 EDT
(In reply to comment #3)
Hi Benoit,

yes, we identified the problem you pointed out. We're working to get a new build with this fix, and we'll let you know as soon as we release it.

Best,
 Marcel

> Hello,
> 
> It still have a bug in the allocation of pathPrefix.
> As you can see you have sized the array with 2 and you want to put in 3
> elements thats caussing a java crash.
> 
> regards
Comment 5 Marcel Gorri CLA 2011-07-26 15:24:29 EDT
(In reply to comment #4)
Hi Benoit,

we've just generated a new build, with some fixes. Can you please try it and see if it is ok?

Best!
 Marcel

> (In reply to comment #3)
> Hi Benoit,
> 
> yes, we identified the problem you pointed out. We're working to get a new
> build with this fix, and we'll let you know as soon as we release it.
> 
> Best,
>  Marcel
> 
> > Hello,
> > 
> > It still have a bug in the allocation of pathPrefix.
> > As you can see you have sized the array with 2 and you want to put in 3
> > elements thats caussing a java crash.
> > 
> > regards
Comment 6 Benoit Malrat CLA 2011-07-27 04:33:26 EDT
Hi Marcel,

It seem to work with the NDK 5c and 6 version on Windows.
I didn't test on linux yet.

Thanks for this quick fix, I can now drop my version of you plugin

Regards,
Benoit



(In reply to comment #5)
> (In reply to comment #4)
> Hi Benoit,
> we've just generated a new build, with some fixes. Can you please try it and
> see if it is ok?
> Best!
>  Marcel
> > (In reply to comment #3)
> > Hi Benoit,
> > 
> > yes, we identified the problem you pointed out. We're working to get a new
> > build with this fix, and we'll let you know as soon as we release it.
> > 
> > Best,
> >  Marcel
> > 
> > > Hello,
> > > 
> > > It still have a bug in the allocation of pathPrefix.
> > > As you can see you have sized the array with 2 and you want to put in 3
> > > elements thats caussing a java crash.
> > > 
> > > regards