Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331934

Summary: [ErrorHandling] Push org.eclipse.ui.statushandlers.AbstractStatusAreaProvider#validFor(StatusAdapter) down to org.eclipse.jface.dialogs.ErrorSupportProvider
Product: [Eclipse Project] Platform Reporter: Troy Bishop <tjbishop>
Component: UIAssignee: Krzysztof Daniel <krzysztof.daniel>
Status: RESOLVED FIXED QA Contact: Susan McCourt <susan>
Severity: enhancement    
Priority: P3 CC: krzysztof.daniel, remy.suen
Version: 3.6.1   
Target Milestone: 3.7 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch proposition
none
mylyn/context/zip none

Description Troy Bishop CLA 2010-12-06 13:36:30 EST 
Build Identifier: 3.6

In Eclipse 3.6 the API org.eclipse.ui.statushandlers.AbstractStatusAreaProvider#validFor(StatusAdapter) was added to prevent the support area composite from being created if implementers felt that the corresponding IStatus did not need a corresponding support tray.  This works great if code uses the StatusManager to handle an IStatus but it does not work if the support provider is used in (for example) an org.eclipse.jface.dialogs.ErrorDialog because AbstractStatusAreaProvider is not accessible in this class.

I would like to request that the API validFor(StatusAdapter) be pushed down to org.eclipse.jface.dialogs.ErrorSupportProvider so that it can be called in ErrorDialog to produce a consistent behaviour between ErrorDialog and StatusManager.

Reproducible: Always
Comment 1 Krzysztof Daniel CLA 2010-12-13 04:51:46 EST 
Created attachment 185043 [details]
patch proposition
Comment 2 Krzysztof Daniel CLA 2010-12-13 04:51:49 EST 
Created attachment 185044 [details]
mylyn/context/zip
Comment 3 Krzysztof Daniel CLA 2010-12-13 05:04:50 EST 
Patch released.