Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331924

Summary: Default severity for missing baseline should be 'Error'
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: API ToolsAssignee: Dani Megert <daniel_megert>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, curtis.windatt.public, Curtis_Windatt, pwebster
Version: 3.6   
Target Milestone: 3.7 M5   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 408699    
Attachments:
Description Flags
Fix none

Description Dani Megert CLA 2010-12-06 11:37:25 EST
3.6.

The default severity for missing baseline should be 'Error'. For background see discussion in bug 315417.
Comment 1 Dani Megert CLA 2010-12-06 11:44:17 EST
Created attachment 184628 [details]
Fix
Comment 2 Curtis Windatt CLA 2010-12-13 14:42:41 EST
Fixed in HEAD.
Comment 3 Dani Megert CLA 2010-12-14 04:00:21 EST
Curtis, thanks for committing my fix but I also have commit rights ;-)
Comment 4 Oleg Besedin CLA 2011-01-04 14:29:47 EST
This results in a number of errors when the current I-build is used for development.

Ironically, it also flags errors in bundles org.eclipse.pde.api.tools and org.eclipse.pde.api.tools.ui :

Description	Resource	Path	Location	Type
An API baseline has not been set for the current workspace.	org.eclipse.pde.api.tools		Unknown	Default API Baseline Problem
An API baseline has not been set for the current workspace.	org.eclipse.pde.api.tools.ui		Unknown	Default API Baseline Problem

Please reconsider this change. If you'd like to go with it, having in mind the effect, I'd hope to see:
- the quickfix added for it, and
- the change needs to be announced on the eclipse-dev mailing list.
Comment 5 Oleg Besedin CLA 2011-01-04 15:01:01 EST
For clarity, here are the steps:

- open a new workspace using current I-build
- check out bundle "org.eclipse.pde.api.tools.ui" from CVS
- check out bundle "org.eclipse.pde.api.tools" from CVS
- note that there is a error reported for both bundles
Comment 6 Curtis Windatt CLA 2011-01-04 15:28:53 EST
(In reply to comment #4)
> Please reconsider this change. If you'd like to go with it, having in mind the
> effect, I'd hope to see:
> - the quickfix added for it, and
> - the change needs to be announced on the eclipse-dev mailing list.

1) A bundle that is marked with the api tooling nature is expected to follow api restrictions.  API Tools can enforce those restrictions, but cannot function correctly without a baseline.  The error is to make it clear that your tooling is not set up correctly.

2) There is a quickfix on the error that opens the preference page.

3) Announcing the change is a reasonable request.  There have been previous attempts to encourage developers to keep their baseline up to date, this is a much more visible step.
Comment 7 Dani Megert CLA 2011-01-05 02:52:16 EST
The error should only be reported if you have a project in your workspace that has API Tools enabled. If that's not the case then we have a bug ==> please open a new bug for that. Otherwise the error is exactly what we expect because otherwise errors in the bundle with enabled API Tools will go unnoticed.

You can always change the default if you want to ignore API Tools.
Comment 8 Dani Megert CLA 2011-01-25 04:01:23 EST
Verified in I20110124-1800.