Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331888

Summary:

The resolution service doesn't search the lowest ordinal in tag/branch path

Product:

z_Archived

Reporter:

Matthias Kappeller <mkappeller>

Component:

Buckminster

Assignee:

buckminster.core-inbox <buckminster.core-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

thomas

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
A patch to let the resolution service recognize multiple tags and branches	thomas: iplog+
mylyn/context/zip	none

Description Matthias Kappeller

2010-12-06 07:33:16 EST

If a Advisor Node defines multiple tags or branches only the highest tag or branch will be recognized by the resolution service.

This can be reproduced with the following CQuery:
https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/Bucky/the.cquery

In this example:
The tag/branch path denotes the tags /tag2,/tag1
The root request is component.a
The RMap provides a svn repository for the component.a

We assume the resolution service finds the following:
1.0.0 in /tag1
1.0.0 in /tag2

With the priorities given by the tag/branch path the best match should be '/tag2'

But the result is '/tag1' and the debug console does print out this:
component.a:osgi.bundle: Using resolver rmap
component.a:osgi.bundle: Using resolver Local resolver
component.a:osgi.bundle: Trying provider local(materialized)
No materialization found for component.a:osgi.bundle
component.a:osgi.bundle: Trying provider local(workspace)
No open workspace project found that corresponds to component.a:osgi.bundle
component.a:osgi.bundle: Trying provider local(target)
component.a:osgi.bundle: Rejecting provider eclipse.platform(plugin/component.a): No component match was found
Downloading https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/Bucky/My.rmap
component.a:osgi.bundle: Using resource map https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/Bucky/My.rmap
component.a:osgi.bundle: Using search path svn
component.a:osgi.bundle: Trying provider svn(https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/{0}?moduleAfterTag&moduleAfterBranch[https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/component.a?moduleAfterTag&moduleAfterBranch])
component.a:osgi.bundle: tags will be searched
Listing remote folder https://testaquery.svn.sourceforge.net/svnroot/testaquery/tags#HEAD
Reading remote file https://testaquery.svn.sourceforge.net/svnroot/testaquery/tags/tag1/component.a/META-INF/MANIFEST.MF#HEAD
component.a:osgi.bundle: Found match 1.0.0.qualifier:/tag1:#8
component.a:osgi.bundle: Using provider svn(https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/{0}?moduleAfterTag&moduleAfterBranch[https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/component.a?moduleAfterTag&moduleAfterBranch])
Reading remote file https://testaquery.svn.sourceforge.net/svnroot/testaquery/tags/tag1/component.a/build.properties#8
Reading remote file https://testaquery.svn.sourceforge.net/svnroot/testaquery/tags/tag1/component.a/.classpath#8
Provider svn(https://testaquery.svn.sourceforge.net/svnroot/testaquery/trunk/component.a?moduleAfterTag&moduleAfterBranch): materializing to /Users/aUser/Documents/workspaces/tmp/plugins/component.a/
Checking out https://testaquery.svn.sourceforge.net/svnroot/testaquery/tags/tag1/component.a using revision 8

As the console shows, the /tag2 isn't recognized anyway.

Comment 1 Matthias Kappeller

2010-12-06 07:40:58 EST

Created attachment 184592 [details]
A patch to let the resolution service recognize multiple tags and branches

With this patch everything woks fine for us.
These lines (which this patch will remove) have been introduced with rev.6558.
I don't see the actual use case for them, so maybe a buckminster comitter might say in which case these lines are necessary.

Comment 2 Matthias Kappeller

2010-12-06 07:41:00 EST

Created attachment 184593 [details]
mylyn/context/zip

Comment 3 Thomas Hallgren

2011-01-26 16:28:24 EST

Patch applied to helios-maintenance branch, rev 11656.

Thanks.