Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331827

Summary:

Orbit should generate Eclipse-SourceReferences headers into MANIFEST.MF

Product:

[Tools] Orbit

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

releng

Assignee:

Martin Oberhuber <mober.at+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Project Inbox <orbit.releng-inbox>

Severity:

normal

Priority:

CC:

david_williams, gunnar, markus.kell.r

Version:

unspecified

Target Milestone:

Indigo M5

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

338447

Attachments:

Description	Flags
pach instructing PDE to generate Orbit Source References	none

Description Martin Oberhuber

2010-12-04 03:23:18 EST

Created attachment 184529 [details]
pach instructing PDE to generate Orbit Source References

Given a binary bundle from Orbit, I want to easily get the related Orbit project from CVS, such that (a) I can make corrections to about files etc, and (b) I get the source for the binary bundle into my workspace for debugging.

PDE has introduced support for generating this directive automatically:
* http://wiki.eclipse.org/PDE/UI/SourceReferences
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=195729
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=243582

Given that Orbit projects use multiple branches, this feature is expected to be especially valuable since it makes it easy to get the correct branch into the Workspace.

Attached patch sets the directive which instructs PDE to generate source references in Orbit (untested). Please run a test build with it to see whether it works as expected.

Comment 1 Martin Oberhuber

2011-01-21 12:35:03 EST

Patch committed, since we also recently discussed this in the January AC meeting: http://wiki.eclipse.org/Architecture_Council/Meetings/January_13_2011

We'll see how it goes.

Comment 2 Gunnar Wagenknecht

2011-02-28 17:24:17 EST

It's interesting. I had expect that such a change would get an announcement on the Orbit dev list (assuming that there was a good discussion at the AC meeting already). Maybe I missed the announcement. But it looks like even David is surprised. There is now a lot discussion on bug 338447 if the header should be removed.

Comment 3 Martin Oberhuber

2011-02-28 18:04:45 EST

Linking to bug 338447.

As you'll see from the history of this bug, it had been sitting assigned to the Orbit inbox for almost 2 months waiting for comments, before I committed the patch.

I guess I had expected Orbit committers to listen to the inbox. Looks like that assumption didn't hold, and a message to the mailing list would have been better.

Comment 4 David Williams

2011-02-28 20:05:04 EST

(In reply to comment #1)
> Patch committed

For future reference, committing a change to 
org.eclipse.orbit.releng.builder
doesn't really change how the build is performed. To do that,  
that project must be tagged, and the builderVersion value updated in the build.cfg file, in releng/maps. 
See http://wiki.eclipse.org/Orbit_Builds#Orbit_Builds_for_Orbit_Builds-masters
(for some details). 
Thanks for contributing.