Bugzilla – Full Text Bug Listing
| Summary: | Polish Use Scan Feature | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Curtis Windatt <curtis.windatt.public> | ||||||
| Component: | API Tools | Assignee: | Michael Rennie <Michael_Rennie> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ankur_sharma, Michael_Rennie | ||||||
| Version: | 3.7 | Flags: | curtis.windatt.public:
review+
ankur_sharma: review- |
||||||
| Target Milestone: | 3.7 M4 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 331954 | ||||||||
| Attachments: |
|
||||||||
|
Description
Curtis Windatt
(In reply to comment #0) > I had no performance issues in my tests. I haven't tried with an overly large > (100+ project workspace) yet. > > Issues: > > 1) I think we should revisit the pref page name. The current one is long > (doesn't fit in the default sized dialog), not very clear and does not start > with 'API' like the other API tooling pages. My suggestions would be: > "API Use Dependencies" > "API Dependency Scans" > "API Use Scans" > Make the API tooling pages have their own branch in the pref tree) > I vote API Use Scans, since that is what the page is for > 2) Problem category should match up exactly with the preference page name. We > need to use a consistent name, otherwise users won't understand where the > problems are coming from. > Agreed. > 3) The problems should be associated with the type name if it can be calculated > so they show up in the editor. This is because there is no charstart / charend on the problems, so they are created on the correct resource, but not in the correct locale. Should be an easy fix. > > 4) Preference page should have a link to the error level page. > We should add one on the baselines page as well to the error/warnings page. > 5) Error levels should not be ignore by default. Currently the user sets up > the scan on the preference page, it asks you if you want to build and you say > "great, go for it". No errors are reported, which is perfect until you realize > that there are no errors being reported period. > As long as we can ensure absolutely no work is done by this new builder if there are no scans, this could be ok. > 6) Is there any value to letting the user change the cache size? As a user I > have know idea what a reasonable value it and whether it would be beneficial > for me to change it. No need to give the user an advanced option unless there > is a definite need by some users. > > 7) The text at the top of the page needs a bit of work. It shouldn't say *the* > api use scan problems. Second sentence should perhaps read "The dependencies > found in the use scans will be compared against workspace projects to ensure > they still exist." Should probably read: "Add, edit or remove API use scans. The references found in the use scans will be compared to projects in the workspace to ensure they still exist." > > 8) Edit locations button should be removed, it adds no real value. Debatable. It allows you a quick way to open the folder and select a related one, rather than remove one you don't want and then have to use the add button to re-add a new one. > > 9) There is no help doc for the page, we should file a bug to remind us to > write doc in M6. Agreed Created attachment 184518 [details]
marker placement
This patch fixes up the marker placement - it set the charstart / end / line number of the enclosing IType, if it can be computed.
Created attachment 184658 [details]
polish fix
This patch contains the marker placement fix as well as:
1. properly sets the new use scan markers in the correct grouping
2. renames the preference page
3. adds a keyword reference for the new preference page
4. removes all use of 'Api' -> changed to 'API'
committed to HEAD +1 Verified in I20101207-2000 |