Bugzilla – Full Text Bug Listing
| Summary: | Missing names and licenses for source features | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | John Arthorne <john.arthorne> | ||||||||||||||||
| Component: | Releng | Assignee: | Kim Moir <kim.moir> | ||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||
| Severity: | normal | ||||||||||||||||||
| Priority: | P3 | CC: | aniefer, kim.moir, Olivier_Thomann, remy.suen | ||||||||||||||||
| Version: | 4.1 | ||||||||||||||||||
| Target Milestone: | 4.1 M7 | ||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||
| OS: | Windows 7 | ||||||||||||||||||
| Whiteboard: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
John Arthorne
Created attachment 184499 [details]
Screen shot
I have no idea where these are defined but I'm assuming you do, Kim. Created attachment 184513 [details]
patch
Don't think that this is related, but as an aside Andrew mentioned that your features now include the new Lucene bundle. You need to update the features to include them and generate the source for the new versions.
Created attachment 184514 [details]
mylyn/context/zip
Created attachment 185128 [details]
patch
I've released the patch and tagged the sdk feature for the next 4.1 build. Andrew, are there any plans to use shared licenses in the 4.1 stream like we do in the 3.7 stream? Not sure why this error is occurring in 4.1. *** Bug 342027 has been marked as a duplicate of this bug. *** So I looked at this today and the problem is that the 3.7 source features that the 4.1 build just consumes from the 3.7 build repos are missing files. For instance, they are missing feature.properties file which defines the feature name and that's why it shows up as blank in the ui. Looking at the 4.1 map files there are a number of binary source features consumed, for instance feature@org.eclipse.jdt=p2IU,id=org.eclipse.jdt.feature.jar,repository=ECLIPSE_PLATFORM_REPO feature@org.eclipse.pde=p2IU,id=org.eclipse.pde.feature.jar,repository=ECLIPSE_PLATFORM_REPO feature@org.eclipse.cvs=p2IU,id=org.eclipse.cvs.feature.jar,repository=ECLIPSE_PLATFORM_REPO plugin@org.eclipse.cvs=p2IU,id=org.eclipse.cvs,repository=ECLIPSE_PLATFORM_REPO feature@org.eclipse.help=p2IU,id=org.eclipse.help.feature.jar,repository=ECLIPSE_PLATFORM_REPO feature@org.eclipse.equinox.p2.user.ui=p2IU,id=org.eclipse.equinox.p2.user.ui.feature.jar,repository=ECLIPSE_PLATFORM_REPO feature@org.eclipse.equinox.p2.core.feature=p2IU,id=org.eclipse.equinox.p2.core.feature.feature.jar,repository=ECLIPSE_PLATFORM_REPO feature@org.eclipse.equinox.p2.extras.feature=p2IU,id=org.eclipse.equinox.p2.extras.feature.feature.jar,repository=ECLIPSE_PLATFORM_REPO feature@org.eclipse.equinox.p2.rcp.feature=p2IU,id=org.eclipse.equinox.p2.rcp.feature.feature.jar,repository=ECLIPSE_PLATFORM_REPO However, I don't seem the associated source features. You can't just generate source features from binary features, you need the actually source artifacts to do that. Andrew, shouldn't the 3.7 source features that are reconsumed by the 4.1 build just be added to the 4.1 map files? *** Bug 340903 has been marked as a duplicate of this bug. *** Yeah we should add them to the map file, that could be enough to fix this Created attachment 193198 [details]
patch
Created attachment 193200 [details]
patch
Okay, I've updated the maps. Hmmm, it seems like the same problem still exists in 4.1 I20110415-1030. Andrew, should I have to tweak the build.properties of the 4.1 sdk feature to stop generating the source features? Created attachment 193513 [details] patch It looks like the Fetch phase will skip fetching features for which there is a generate.feature@ properties in the containing feature's build.properties. So, yes it looks like we should remove those generate.feature properties for any source feature that we don't need to recreate. Here is a patch that removes the following from org.eclipse.sdk generate.feature@org.eclipse.jdt.source generate.feature@org.eclipse.pde.source generate.feature@org.eclipse.pde.p2.source generate.feature@org.eclipse.cvs.source generate.feature@org.eclipse.help.source and from org.eclipse.platform: generate.feature@org.eclipse.equinox.p2.user.ui.source The previous change to the map files is still required. Thanks Andrew, patch released and tagged for next i-build. Verified that this is fixed in 4.1 build I20110419-2200. |