Bugzilla – Full Text Bug Listing
| Summary: | NLS: Severities for Code Analysis Problem Preferences not externalized for translation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Kit Lo <kitlo> | ||||||
| Component: | cdt-codan | Assignee: | Project Inbox <cdt-core-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Elena Laskavaia <elaskavaia.cdt> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | cdtdoug, elaskavaia.cdt, vivkong, yevshif | ||||||
| Version: | 8.0 | ||||||||
| Target Milestone: | 8.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Problem still exists in 8.0.0-I201103111317 build. Created attachment 194979 [details]
proposed patch for HEAD
Hi Alena, can you please review the attached patch? I hope I have replaced all the toString() to toTranslatableString() but I just want to be sure. Thanks.
I need to look at it more, please don't commit yet. These values used in profiles, we should not attempt to save translated value in there. Mapping between translated values and original values can be tricky (In reply to comment #3) > I need to look at it more, please don't commit yet. These values used in > profiles, we should not attempt to save translated value in there. Mapping > between translated values and original values can be tricky Hi Alena, do you think we can get this fixed in RC2? +1 please commit the patch (I lost my commit rights because of legal issues) (In reply to comment #5) > +1 > please commit the patch (I lost my commit rights because of legal issues) Thanks for your review. Fixed in HEAD *** cdt cvs genie on behalf of vkong *** Bug 331788 - NLS: Severities for Code Analysis Problem Preferences not externalized for translation [*] CodanSeverity.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/model/CodanSeverity.java?root=Tools_Project&r1=1.8&r2=1.9 [*] Messages.properties 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/Messages.properties?root=Tools_Project&r1=1.1&r2=1.2 [*] Messages.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/Messages.java?root=Tools_Project&r1=1.4&r2=1.5 [*] build.properties 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/build.properties?root=Tools_Project&r1=1.6&r2=1.7 [*] ProblemsTreeEditor.java 1.23 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.ui/src/org/eclipse/cdt/codan/internal/ui/preferences/ProblemsTreeEditor.java?root=Tools_Project&r1=1.22&r2=1.23 [*] ParametersComposite.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.ui/src/org/eclipse/cdt/codan/internal/ui/widgets/ParametersComposite.java?root=Tools_Project&r1=1.11&r2=1.12 |
Created attachment 184484 [details] screen capture Build: 8.0.0-I201011050851 Severities ("Info", "Warning", "Error") for Code Analysis Problem Preferences not externalized for translation.