Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331777

Summary:

[releng] Is it possible to add context debug bundle to the builds?

Product:

[Eclipse Project] e4

Reporter:

Oleg Besedin <ob1.eclipse>

Component:

Assignee:

Andrew Niefer <aniefer>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

pwebster, remy.suen

Version:

unspecified

Target Milestone:

4.1 M6

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

331237

Bug Blocks:

Attachments:

Description	Flags
compile errors	none
Dependency patch v1	none

Description Oleg Besedin

2010-12-03 10:35:19 EST

Is it possible to add context debug bundle 

  e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.core.contexts.debug

to the builds? (And, once it is there, add it to the e4.ui.psf in org.eclipse.e4.ui.releng?)

Comment 1 Andrew Niefer

2010-12-06 14:43:17 EST

I have added the org.eclipse.e4.core.contexts.debug bundle to the org.eclipse.e4.rcp feature for 4.1 SDK and to the org.eclipse.e4.ui.feature for the 0.11 build.

Comment 2 Andrew Niefer

2010-12-06 17:37:39 EST

Created attachment 184670 [details]
compile errors

There was a compile error in the test build, I don't know if we just don't have everything tagged properly or what.  But everyone is gone home so I've just reverted the map file entries for these changes to the two features so the build will pass tonight.


<problem categoryID="50" charEnd="2006" charStart="1990" id="UndefinedField" line="51" problemID="33554502" severity="ERROR">
   <message value="ICategory_general cannot be resolved or is not a field"/>
   <source_context sourceEnd="60" sourceStart="44" value="tags.add(&quot;categoryTag:&quot; + WorkbenchMessages.ICategory_general); //$NON-NLS-1$"/>
   <arguments>
     <argument value="ICategory_general"/>
   </arguments>
</problem>

Comment 3 Remy Suen

2010-12-07 08:33:01 EST

The ICategory_general field does _not_ exist in 3.x but is there in 4.x.

I think this is why the compilation process failed, as we perform the 0.11 build on top of 3.x.

Comment 4 Paul Webster

2011-02-03 10:21:05 EST

Did this bundle make it in?

PW

Comment 5 Remy Suen

2011-02-03 10:40:40 EST

Created attachment 188245 [details]
Dependency patch v1

Patch to get ICategory_general from somewhere else.

Comment 6 Remy Suen

2011-02-03 10:41:15 EST

(In reply to comment #5)
> Created attachment 188245 [details]
> Dependency patch v1

I've released this to HEAD. We should try to incorporate this into the build again.

Comment 7 Paul Webster

2011-02-03 10:41:55 EST

With the switch in build order, this problem should have simply gone away.

PW

Comment 8 Remy Suen

2011-02-04 08:16:15 EST

In any case, we'll need to add it back into the feature so it gets included in the 4.1 SDK.

Comment 9 Andrew Niefer

2011-02-04 13:17:52 EST

(In reply to comment #1)
> I have added the org.eclipse.e4.core.contexts.debug bundle to the
> org.eclipse.e4.rcp feature for 4.1 SDK and to the org.eclipse.e4.ui.feature for
> the 0.11 build.

The changes here were never actually undone.  The map file was just not updated to include them.

I have now updated the map file so the the contexts.debug bundle should be in the next 4.1 build

Comment 10 Remy Suen

2011-02-11 09:43:19 EST

(In reply to comment #9)
> I have now updated the map file so the the contexts.debug bundle should be in
> the next 4.1 build

Verified to be in I20110210-2002. At the moment, you can only access it via Ctrl+3.