Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331764

Summary: Selecting a project in the "Configure Git Repository" dialog is difficult
Product: [Technology] EGit Reporter: Philipp Thun <philipp.thun>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: remy.suen
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Screenshots none

Description Philipp Thun CLA 2010-12-03 08:43:53 EST 
Build Identifier: 20100917-0705

Within the "Configure Git Repository" dialog a repository location has to be specified. In case no suitable repository exists, the user must select the project and then click the "Create Repository" button.

A Windows 7 user must not click on the check box to select the project, as this has no effect. Using Ubuntu 10.04 it is possible to click on the check box so that the project gets selected. As this UI contains a check box it is quite straightforward to click on it from my point of view, thus the current reaction is insufficient.

Reproducible: Always

Steps to Reproduce:
1. Create a new, empty project
2. Share as Git project (Context menu on project -> Team -> Share Project... -> Git)
3. Click on check box
Comment 1 Philipp Thun CLA 2010-12-03 08:44:39 EST 
Created attachment 184461 [details]
Screenshots
Comment 2 Remy Suen CLA 2010-12-03 10:30:20 EST 
I feel that the fact that clicking on the checkbox doesn't actually check it off is more confusing to the user but that's another topic of discussion I suppose.

The checkbox is a very small button in the tree and clicking on it is a very explicit gesture. If I wanted to select the row I could click pretty much click anywhere else on the row, why would I be clicking on the checkbox if my intent was to select the row?

Are there other applications on Windows 7 that exhibits this behaviour?
Comment 3 Philipp Thun CLA 2010-12-03 11:16:47 EST 
If you already know how the UI works, i.e. that you have to select the row, you will simply click on it - I agree. But if you see this dialog for the first time you might just try to click on the check box - this is at least what I tried to do.

I still believe that clicking on the check box is a 'normal' thing that a user could do. When I did so and nothing happend, I had to ask colleague for help...

I am aware of the fact that I am new to EGit but with regards to finding usability issues I believe this is an advantage.
Comment 4 Remy Suen CLA 2010-12-03 11:27:00 EST 
(In reply to comment #3)
> If you already know how the UI works, i.e. that you have to select the row, you
> will simply click on it - I agree.

Actually, Philipp, I don't really know what this UI does. ;)

The wizard makes little sense to me. It is not clear to me what the difference between selecting the items and checking them are.

What I _do_ know is that when I get this wizard for sharing a project that's not under version control, I can click in the checkbox but it will not check it (which is extremely counter-intuitive in my opinion :)).

> But if you see this dialog for the first
> time you might just try to click on the check box - this is at least what I
> tried to do.

Yes, I agree with this thought process.

> I still believe that clicking on the check box is a 'normal' thing that a user
> could do. When I did so and nothing happend, I had to ask colleague for help...

Did you expect clicking the checkbox to _tick_ the checkbox (which it will _not_ do)?

Or did you expect that clicking the checkbox would _select_ the row?
Comment 5 Remy Suen CLA 2011-01-26 10:28:18 EST 
According to Gerrit, it seems that Mathias has released this change.

My opinion of this UI has not changed (unless the UI itself has changed since December). In any case, I suppose this bug can be closed.
Comment 6 Philipp Thun CLA 2011-01-28 05:01:19 EST 
http://egit.eclipse.org/r/2006