Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331715

Summary:

Support for rectilinear grids

Product:

[Modeling] Graphiti

Reporter:

Volker Wegert <eclipse>

Component:

Core

Assignee:

Michael Wenz <michael.wenz>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

michael.wenz, tim.kaiser

Version:

0.7.0

Flags:

michael.wenz: indigo+

Target Milestone:

0.8.0

Hardware:

All

OS:

All

Whiteboard:

Indigo M4 theme_round_offs

Attachments:

Description	Flags
proposed patch	none

Description Volker Wegert

2010-12-02 15:52:09 EST

Build Identifier: 

In 0.7.0, Graphiti only supports quadratic grids. For one of my editors, I need a rectilinear grid. From what I can see, this would be rather easy to implement, but not without changing the Graphiti model. I'll provide a patch that adds support for non-quadratic grids without (hopefully) breaking the existing editors.

Reproducible: Always

Comment 1 Volker Wegert

2010-12-02 15:52:51 EST

Created attachment 184402 [details]
proposed patch

Comment 2 Michael Wenz

2010-12-13 10:12:32 EST

Thanks for the enhancement request and the patch.

We discussed metamodel extensions like these (we also had another similar case) and decided to not go for using these kind of "self healing" EMF mechanisms where we have to rely on loading and saving a diagram to upgrade it to a newer version of the Graphiti metamodel. The reason was simply that we think we will lose track with many of such changes in the future.

Instead we decided to go for a more evolutionary way for now and move forward in a strictly compatible fassion. That is why we were not able to include your patch, although it didn't break anything (also no old diagrams).

Instead I implemented this feature using an additional attribute for the vertical grid unit an the diagram. Services and the consumation inside the framework are adapted accordingly. Tests are supplied.

Part of 0.8.0 in Indigo M4.

Hope this works for you as well. Just let me know in case it does not.

Michael

Comment 3 Michael Wenz

2011-04-29 03:30:12 EDT

Comment on attachment 184402 [details]
proposed patch

Marked as obsolete (was not used) to clean-up IP log

Comment 4 Michael Wenz

2011-06-24 09:05:08 EDT

Part of Graphiti Indigo 0.8.0