Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331690

Summary:	[Trim] [Min/Max] Update our EventBroker usage in add-ons
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Eric Moffatt <emoffatt>
Status:	VERIFIED FIXED	QA Contact:	Eric Moffatt <emoffatt>
Severity:	normal
Priority:	P3	CC:	emoffatt, Lars.Vogel
Version:	4.3
Target Milestone:	4.4 M3
Hardware:	PC
OS:	Linux
Whiteboard:

Description Paul Webster

2010-12-02 11:25:05 EST

Our add-ons currently subscribe handlers to one or more topics, and are effected by Bug 331645 ex:

broker.subscribe(
UIEvents.buildTopic(UIEvents.KeyBinding.TOPIC, UIEvents.KeyBinding.PARAMETERS),
additionHandler);

The UIEvents constants can be re-structured so UIEvents.buildTopic(*) is no longer needed, and then we can use the "new way" of subscribing to events:

@Inject @Optional
public void event(@EventTopic(TOPIC) Object data) {
}

PW

Comment 1 Lars Vogel

2013-03-08 08:07:58 EST

Any plans to convert the usage of EventBroker to DI for Eclipse 4.3? I could try to provide patches if you would consider them.

Comment 2 Paul Webster

2013-03-08 08:14:39 EST

Hi Lars,

Pick an Addon and push something to Gerrit and we'll get it reviewed.

PW

Comment 3 Lars Vogel

2013-09-06 10:32:34 EDT

Gerrit review for the MinMax-Addon: https://git.eclipse.org/r/16191

Comment 4 Paul Webster

2013-09-09 15:39:10 EDT

Eric, could you please review https://git.eclipse.org/r/16191

PW

Comment 5 Eric Moffatt

2013-09-24 13:52:18 EDT

Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f350f9230f91a74928986fefe812bd91e29ac8d6

Thanks Lars !

Comment 6 Eric Moffatt

2013-10-29 10:46:47 EDT

Verified (visually) in 4.4.0.I20131028-2000.