Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331688

Summary: RFC: Remove empty lines (containing only whitespace) when merging entries for a change in the same file, but different function.
Product: [Tools] Linux Tools Reporter: Severin Gehwolf <sgehwolf>
Component: ChangeLogAssignee: Phil Muldoon <pmuldoon>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: jjohnstn, linux.changelog-inbox
Version: 0.7.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch implementing the proposed functionality (including a test for it). none

Description Severin Gehwolf CLA 2010-12-02 11:08:25 EST 
Created attachment 184363 [details]
Patch implementing the proposed functionality (including a test for it).

Imagine the following existing ChangeLog:

2010-12-02  Some Author  <will@example.com>

    * path/to/fileA.c (main): Some change.
    <= here is a tab
    * path/to/fileB.c: New file.

2010-10-08  Author B  <b@bull.com>

   ....

When merging a new change in function "myfunction" on the same day in fileA.c current code would produce:

2010-12-02  Some Author  <will@example.com>

    * path/to/fileA.c (main): Some change.
    
    (myfunction): 
    * path/to/fileB.c: New file.

2010-10-08  Author B  <b@bull.com>

   ....

The with the proposed patch applied the code produces (note the removed "empty" line):

2010-12-02  Some Author  <will@example.com>

    * path/to/fileA.c (main): Some change.
    (myfunction): 
    * path/to/fileB.c: New file.

2010-10-08  Author B  <b@bull.com>

   ....

Patch including a test for this is attached. Let me know what you think. Thanks!
Comment 1 Jeff Johnston CLA 2010-12-10 15:28:23 EST 
(In reply to comment #0)
> Created an attachment (id=184363) [details]
> Patch implementing the proposed functionality (including a test for it).
> 
> Imagine the following existing ChangeLog:
> 
> 2010-12-02  Some Author  <will@example.com>
> 
>     * path/to/fileA.c (main): Some change.
>     <= here is a tab
>     * path/to/fileB.c: New file.
> 
> 2010-10-08  Author B  <b@bull.com>
> 
>    ....
> 
> When merging a new change in function "myfunction" on the same day in fileA.c
> current code would produce:
> 
> 2010-12-02  Some Author  <will@example.com>
> 
>     * path/to/fileA.c (main): Some change.
> 
>     (myfunction): 
>     * path/to/fileB.c: New file.
> 
> 2010-10-08  Author B  <b@bull.com>
> 
>    ....
> 
> The with the proposed patch applied the code produces (note the removed "empty"
> line):
> 
> 2010-12-02  Some Author  <will@example.com>
> 
>     * path/to/fileA.c (main): Some change.
>     (myfunction): 
>     * path/to/fileB.c: New file.
> 
> 2010-10-08  Author B  <b@bull.com>
> 
>    ....
> 
> Patch including a test for this is attached. Let me know what you think.
> Thanks!

Sure, it obviously doesn't regress your other tests, so go ahead.
Comment 2 Severin Gehwolf CLA 2010-12-10 18:06:33 EST 
Committed (Revision 27091). Closing this bug.