Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331668

Summary:

ESelectionService should not notify listeners if the active part does not post selections

Product:

[Eclipse Project] e4

Reporter:

Remy Suen <remy.suen>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

RESOLVED FIXED

QA Contact:

Remy Suen <remy.suen>

Severity:

major

Priority:

CC:

daniel_megert, eiswind

Version:

1.0

Target Milestone:

4.1 M4

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
SelectionService patch v1	none
SelectionService patch v2	none
ESelectionService patch v1	none

Description Remy Suen

2010-12-02 09:09:30 EST

Even if you do not set a selection provider for your IWorkbenchPart implementation, we are still propagating selection events for that part within the given workbench window.

Comment 1 Remy Suen

2010-12-02 09:11:13 EST

Created attachment 184351 [details]
SelectionService patch v1

We should ignore selection events from parts that haven't registered a selection provider.

Comment 2 Remy Suen

2010-12-02 09:22:20 EST

Created attachment 184352 [details]
SelectionService patch v2

Actually, we should be preventing ISources.ACTIVE_CURRENT_SELECTION from changing also.

Comment 3 Remy Suen

2010-12-02 13:26:19 EST

Created attachment 184376 [details]
ESelectionService patch v1

The ESS should only send out notifications if the part actually posts selections.

Comment 4 Remy Suen

2010-12-02 13:27:38 EST

Fix delivered to HEAD. Thank you very much for the bug report, Thomas!

Comment 5 Thomas Kratz

2010-12-04 03:46:10 EST

Thanks Remy, works like a charm now