Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331640

Summary: Clone wizard: Illegal remote name is not checked
Product: [Technology] EGit Reporter: Philipp Thun <philipp.thun>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: robin
Version: unspecifiedKeywords: bugday, helpwanted
Target Milestone: 3.2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Philipp Thun CLA 2010-12-02 05:06:51 EST 
Build Identifier: 20100917-0705

When entering an illegal value as remote name for cloned branches within the clone wizard it is possible to click Finish. Only after cloning is (nearly) complete an error message is shown:

Failure updating tracking ref refs/remotes/&&&//(§$"#הצההצה�p�\\\<>::/@@/master: The filename, directory name, or volume label syntax is incorrect

or

Failure updating tracking ref refs/remotes/ /master: The system cannot find the path specified

Reproducible: Always

Steps to Reproduce:
1. Clone a Git repository (e.g. Git Repositories view -> Clone a Git
Repository... button)
2. Enter 'http://egit.eclipse.org/egit.git' as URI
3. Click Next twice
4. Enter '&&&//(§$"#הצההצה�p�\\\<>::/@@' or ' ' as remote name
5. Click Finish
Comment 1 Robin Stocker CLA 2013-09-27 12:07:21 EDT 
It should be checked with Repository.isValidRefName(Constants.R_REMOTES + remoteName + "/test").
Comment 2 Robin Stocker CLA 2013-10-31 17:58:17 EDT 
Fixed by Michael Keppler (who started contributing via the EclipseCon Europe Hackathon): https://git.eclipse.org/c/egit/egit.git/commit/?id=db74a44d03d182cf7b82d5abcaad336fbc20210f