Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331611

Summary: WebXmlUpdater - multiple method calls fail to update model
Product: [WebTools] Java Server Faces Reporter: Ian Trimble <ian.trimble>
Component: CoreAssignee: Ian Trimble <ian.trimble>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: dimitar.giormov, raghunathan.srinivasan
Version: 3.3   
Target Milestone: 3.2.3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 323185    
Bug Blocks:    

Description Ian Trimble CLA 2010-12-01 16:26:07 EST
When multiple WebXmlUpdater methods are called sequentially, only the first method will succeed.

For example (where "updater" is an instance of WebXmlUpdater), this succeeds:

    updater.addServlet("Foo", "org.foo.Foo", "1");

but this successfully adds only the servlet and not the context parameter:

    updater.addServlet("Foo", "org.foo.Foo", "1");
    updater.addContextParam("Bar", "Hmm", "Stuff");

This causes two failing tests in the core tests suite:
 - testAddContextParam, and
 - testAddServletMapping
Comment 1 Raghunathan Srinivasan CLA 2010-12-01 17:00:30 EST
Please review if this is caused by the fix for bug 323185
Comment 2 Ian Trimble CLA 2010-12-02 12:20:11 EST
(In reply to comment #1)
> Please review if this is caused by the fix for bug 323185

If I reverse the patch for bug 323185, things work correctly.
Comment 3 Dimitar Giormov CLA 2010-12-06 02:52:07 EST
Hi the dependent bug was fixed. I have run your tests and they passed.
Hopefully you can close the issue now.
Comment 4 Ian Trimble CLA 2010-12-06 11:52:38 EST
Fix for blocking bug has corrected the problem.