Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331596

Summary: EAR shouldn't be allowed to be dragged/dropped into itself or another EAR
Product: [WebTools] WTP Java EE Tools Reporter: Aidyl Kareh <amkareh>
Component: jst.j2eeAssignee: Aidyl Kareh <amkareh>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: amkareh, ccc, jsholl
Version: 3.2Flags: cbridgha: review+
Target Milestone: 3.2.3   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
Proposed Patch ccc: iplog+

Description Aidyl Kareh CLA 2010-12-01 14:45:30 EST 
Build Identifier: WTP 3.2.3

In the Project Explorer view, a user can drag an EAR into its own deployment descriptor node or the project node itself. This will cause an entry for the EAR to be added into the Deployment Assembly, which shouldn't be allowed.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-12-01 14:55:04 EST 
Created attachment 184297 [details]
Proposed Patch

Patch fixes a bug in the Drop Assistant's validateDrop() logic where it was finding that this was not a valid scenario but was incorrectly overwriting the status and returning that it was valid.
Comment 2 Chuck Bridgham CLA 2010-12-01 17:08:33 EST 
approve
Comment 3 Carl Anderson CLA 2010-12-01 19:45:23 EST 
Committed to R3_2_maintenance and HEAD for WTP 3.2.3 and WTP 3.3