Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331554

Summary: Remove Draw2d dependencies from AbstractEditPartViewer
Product: [Tools] GEF Reporter: Yuri <yymmss>
Component: GEF-Legacy GEF (MVC)Assignee: gef-inbox <gef-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: minor    
Priority: P3 CC: fredrik.attebrant, nyssen
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Yuri CLA 2010-12-01 10:18:44 EST 
Build Identifier: 20100917-0705

AbstractEditPartViewer is supposed to be base for various editors, including those not based on draw2d. A few methods of AbstractEditPartViewer are taking arguments of org.eclipse.draw2d.geometry.Point which creates a dependency on draw2d plugin.
If AbstractEditPartViewer is there to indeed let people implement their custom viewers this dependency should be eliminated. For example using swt point instead of draw2d point.

Reproducible: Always

Steps to Reproduce:
Just look into AbstractEditPartViewer class.
Comment 1 Alexander Nyßen CLA 2011-09-28 15:54:34 EDT 
That is something we cannot change in the 3.x development stream to to API restrictions. However, in the GEF 4.0 branch we could remove those dependencies by porting GEF (MVC) to use the new Geometry API (developed in terms of bug #355997), which is independent from Draw2d.
Comment 2 Alexander Nyßen CLA 2012-03-11 14:58:59 EDT 
Changed title to indicate this is a GEF4 topic. When porting to the new Geometry API, AbstractEditPartViewer should indeed not retain any dependencies on Draw2d.
Comment 3 Alexander Nyßen CLA 2014-03-04 15:28:05 EST 
Within the newly provided GEF4 MVC component the transferred IVisualViewer is solely dependent on our own GEF4 Geometry API and does not have any Draw2d dependencies. As such, the problem is being resolved there. 

For GEF 3.x, resolving this as wont fix, as it implies an incompatible API change.