Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331552

Summary:

[disassembly] Need a way to insert more than one source line

Product:

[Tools] CDT

Reporter:

Anton Leherbauer <aleherb+eclipse>

Component:

cdt-debug-dsf

Assignee:

Anton Leherbauer <aleherb+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Pawel Piech <pawel.1.piech>

Severity:

enhancement

Priority:

CC:

cdtdoug

Version:

7.0

Target Milestone:

7.0.2

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

331655

Attachments:

Description	Flags
Small enhancement	aleherb+eclipse: iplog-

Description Anton Leherbauer

2010-12-01 10:12:18 EST

Currently the disassembly view allows to insert at most one source line per instruction, but it would make sense to allow a range of source lines.

Comment 1 Anton Leherbauer

2010-12-02 06:48:09 EST

Created attachment 184340 [details]
Small enhancement

This enhances the IDisassemblyPartCallback interface by an additional method "insertSource" which allows to specify a line range (firstLine and lastLine) instead of a single line number.

Comment 2 Anton Leherbauer

2010-12-02 07:05:22 EST

Committed to cdt_7_0 and HEAD.

Comment 3 CDT Genie

2010-12-02 07:23:03 EST

*** cdt cvs genie on behalf of aleherbau ***
Bug 331552 - [disassembly] Need a way to insert more than one source line

[*] DisassemblyPart.java 1.31.2.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java?root=Tools_Project&r1=1.31.2.5&r2=1.31.2.6
[*] SourcePosition.java 1.1.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/SourcePosition.java?root=Tools_Project&r1=1.1&r2=1.1.2.1

[*] DisassemblyDocument.java 1.8.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/model/DisassemblyDocument.java?root=Tools_Project&r1=1.8.2.2&r2=1.8.2.3

[*] IDisassemblyPartCallback.java 1.1.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyPartCallback.java?root=Tools_Project&r1=1.1&r2=1.1.2.1

[*] IDisassemblyPartCallback.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyPartCallback.java?root=Tools_Project&r1=1.1&r2=1.2

[*] DisassemblyPart.java 1.42 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java?root=Tools_Project&r1=1.41&r2=1.42
[*] SourcePosition.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/SourcePosition.java?root=Tools_Project&r1=1.1&r2=1.2

[*] DisassemblyDocument.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/model/DisassemblyDocument.java?root=Tools_Project&r1=1.10&r2=1.11