Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331486

Summary:	Open MPI launch configuration defaults not loaded
Product:	[Tools] PTP	Reporter:	Greg Watson <g.watson>
Component:	RM.Open MPI	Assignee:	Greg Watson <g.watson>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	5.0
Hardware:	All
OS:	All
Whiteboard:

Description Greg Watson

2010-11-30 19:29:36 EST

(First reported by Bob Fuhrer)

I noticed that when creating a new X10DT launch configuration using the OpenMPI transport using the launch configuration editor (as opposed to a launch shortcut), the Communication Interface page of the launch configuration editor showed invalid values. In particular, "Number of processes" was 0, and "Use default arguments" was unchecked, and the "Arguments" field was empty.

It seems this was because no one had called OpenMPILaunchConfigurationDefaults.loadDefaults() early enough.

The patch below calls loadDefaults() from BasicOpenMpiRMLaunchConfigurationDynamicTab.setDefaults(), and fixes the problem I was observing, but I'm not sure this is the right place to do that.

In fact, it seems odd that clients of OpenMPILaunchConfigurationDefaults should need to call OpenMPILaunchConfigurationDefaults.loadDefaults() at all. Shouldn't this be called from the bundle activator's startup() method? loadDefaults() seems to rely only on a bundle resource file, so it seems safe to call at bundle activation time.

Comment 1 Greg Watson

2010-11-30 19:30:17 EST

Yes, it was missing from the plugin start method (the equivalent MPICH2 version is correct). I've added it now.

Thanks!