Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331467

Summary: [LTTng] Add a latency analysis compoment
Product: z_Archived Reporter: Francois Chouinard <fchouinard>
Component: LinuxToolsAssignee: Bernd Hufmann <bernd.hufmann>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: enhancement    
Priority: P3 CC: abdelhaq.saoudi, ali.jawhar, bernd.hufmann, INF4990.A2010, mathieu.denis, so.mailloux
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 354272, 355084, 355141    
Bug Blocks: 290046    
Attachments:
Description Flags
Patch adding a new TmfView where latency analysis charts are displayed.
none
Latency View (updated)
none
Latency View icons (zipped)
none
Update for toside 0.7.0
none
Latency Analysis Icons
none
Update icons path
none
New version of latency analysis jjohnstn: iplog+

Description Francois Chouinard CLA 2010-11-30 14:27:38 EST
It would be useful to add a latency analysis component to the LTTng integration in Eclipse.

The idea is to scan an LTTng trace, determine the elapsed time between 2 related events (the latency), and then to plot the distribution of the latencies.
Comment 1 Philippe Sawicki CLA 2010-12-03 01:04:27 EST
Created attachment 184440 [details]
Patch adding a new TmfView where latency analysis charts are displayed.

Based on revision 27050.
Comment 2 Philippe Sawicki CLA 2010-12-03 01:18:39 EST
Here is a patch adding a latency analysis component to LTTng.

This patch adds a new TmfView named "Latency View", which displays two charts :
 * A scatter plot of latency times vs trace times
 * A histogram of the number of events sharing the same latency times.

Also allows the user to increase/decrease the size of the histogram bars, display the list of latency events pairs and add/remove custom latency events pairs.

The latency computation is implemented as a State pattern in an Analyser, allowing for further refinements or features in the future by adding new states.

Developed by me (Philippe Sawicki), Ali Jawhar, Sophie Mailloux and Abdelhaq Saoudi of École Polytechnique de Montréal.
Comment 3 Francois Chouinard CLA 2010-12-15 18:02:31 EST
Created attachment 185278 [details]
Latency View (updated)

Replaces the previous patch which is problematic.
Comment 4 Francois Chouinard CLA 2010-12-15 18:03:39 EST
Created attachment 185279 [details]
Latency View icons (zipped)

Separate attachment for the (binary) icons
Comment 5 Mathieu Denis CLA 2011-08-08 12:00:30 EDT
Created attachment 201090 [details]
Update for toside 0.7.0

Must apply the patch from Francois before this one. Useful for those who already have the component in their packages.
Comment 6 Mathieu Denis CLA 2011-08-10 16:40:49 EDT
Created attachment 201276 [details]
Latency Analysis Icons

Shorter list of icons since there are some from the original package of Francois that are already in the package lttng.ui.

These icons need to be placed into a new folder named latency/ under icons/ folder of the package org.eclipse.linuxtools.lttng.ui
Comment 7 Mathieu Denis CLA 2011-08-10 17:17:37 EDT
Created attachment 201280 [details]
Update icons path

Correct the latency view icons by itself. No need to download the Latency View icons separately (tested in git perspective).

This patch must be applied at the base of the package org.eclipse.linuxtools.lttng.ui
Comment 8 Ali Jawhar CLA 2011-11-13 19:56:05 EST
I, Ali Jawhar, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by École Polytechnique de Montréal to make this contribution under the EPL.
Comment 9 Philippe Sawicki CLA 2011-11-15 23:34:00 EST
I, Philippe Sawicki, declare that I developed attached code from scratch, without
referencing any 3rd party materials except material licensed under the EPL. I
am authorized by École Polytechnique de Montréal to make this contribution
under the EPL.
Comment 10 abdelhaq saoudi CLA 2012-01-23 16:12:32 EST
I, Abdelhaq Saoudi, declare that I developed attached code from scratch,
without referencing any 3rd party materials except material licensed under the EPL. I am authorized by École Polytechnique de Montréal to make this contribution under the EPL.
Comment 11 Sophie Mailloux CLA 2012-01-24 10:11:43 EST
I, Sophie Mailloux, declare that I developed attached code from scratch,
without referencing any 3rd party materials except material licensed under the
EPL. I am authorized by École Polytechnique de Montréal to make this
contribution under the EPL.
Comment 12 Bernd Hufmann CLA 2012-01-24 11:38:43 EST
Created attachment 209983 [details]
New version of latency analysis

This patch contains the implementation of a latency analysis feature. It is based on the contribution in attachment 184440 [details] done be the students. The new implementation has the following main changes:

- Model-View-Control implementation to decouple model and views
- Re-use of the Histogram model for the Latency Distribution graph
- Improved view synchronization
- Some bug fixes in widgets

Additionally, this patch contains the refactored code for git that was done in attachment 201090 [details].
Comment 13 Andrew Overholt CLA 2012-01-24 16:01:11 EST
Has a CQ been opened for this/these contribution(s)?
Comment 14 Bernd Hufmann CLA 2012-01-24 16:10:40 EST
(In reply to comment #13)
> Has a CQ been opened for this/these contribution(s)?

Yes, I opened one today. 
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=5996

/Bernd
Comment 15 Bernd Hufmann CLA 2012-02-14 09:00:22 EST
Latency Analysis Feature (as in attachment 209983 [details]) has been committed after approved CQ.
Comment 16 Francois Chouinard CLA 2012-03-26 14:04:40 EDT
Delivered in 0.10.0