Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331466

Summary:

Please stop using single letter template parameters by default when generating templates

Product:

[Modeling] Acceleo

Reporter:

Glenview Jeff <junk>

Component:

Core

Assignee:

Project Inbox <acceleo-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

laurent.goubet

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
tentative patch	none

Description Glenview Jeff

2010-11-30 14:19:02 EST

Build Identifier: M20100211-1343

Please stop using single letter template parameters by default when generating templates, especially using the letter i.  When you generate a template from a file, the template that gets created by default uses the first letter of the name of the parameter type.  

This is bad practice in general to name a variable with a single letter.  How about aTypeName/anTypeName instead?

Specifically, I'd even consider it a bug that the letter i is used, given that it becomes inaccessible inside a loop.

Please consider this as a companion request to obsolete the i syntax altogether and come up with a special name for the iterator that is not normally a valid variable name such as [i$/]

Thanks!


Reproducible: Always

Steps to Reproduce:
See above.

Comment 1 Laurent Goubet

2011-01-25 05:30:53 EST

Created attachment 187506 [details]
tentative patch

This patch changes all of the completion proposals containing "variable" names to longer, better describing names.

Comment 2 Laurent Goubet

2011-02-07 09:33:50 EST

Patch commited on both 3.0 maintenance and HEAD. Will be available in 3.0.2RC3 and 3.1.0M6