Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331401

Summary:	Fix feature identifier and version
Product:	[Eclipse Project] e4	Reporter:	Martina Galabova <martina.galabova>
Component:	Search	Assignee:	Project Inbox <e4.search-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	danail.branekov, dimitar.georgiev, martina.galabova, pwebster
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	331418

Description Martina Galabova

2010-11-30 04:20:38 EST

Please change org.eclipse.platform.discovery feature identifier to end in .feature, so that it follows the convention of the other e4 projects. This would take place in:
1) feature.xml-s
2) the search.map
3) the master feature

Also change the plug-in version to 0.11.0.qualifier.

Cheers, 
Martina

Comment 1 Martina Galabova

2010-11-30 04:30:22 EST

Hi, 

 I changed feature.xmls and I know how to change the search.map file, but what is "the master feature"?

Cheers,
Martina

Comment 2 Paul Webster

2010-11-30 07:14:26 EST

You need to create a master "build" features, like org.eclipse.e4.search.master.  That will control all of the search features that need built, initially it should include the main search feature and the examples one.

Then Andrew will add it to the main build master feature, and your plugins will get built: bug 331418

PW

Comment 3 Dimitar Georgiev

2010-11-30 07:20:02 EST

(In reply to comment #2)
> You need to create a master "build" features, like
> org.eclipse.e4.search.master.  That will control all of the search features
> that need built, initially it should include the main search feature and the
> examples one.
> 
> Then Andrew will add it to the main build master feature, and your plugins will
> get built: bug 331418
> 
> PW

I guess Marti's question was where the main build master feature resides and what its name is. Even if Andrew is at this point the person who will modify it, it will still be good if we know where to check it out from, and import it in our local workspaces. This way, in the future when, for example, we change the feature version, we can validate we've not broken the build master feature's manifest.

Cheers, Dimitar

Comment 4 Paul Webster

2010-11-30 08:19:28 EST

Sure, here's the info:

All of our releng projects are in /cvsroot/eclipse e4/releng

I usually just check the e4/releng project out, although you can check out only your org.eclipse.e4.search.releng project.

All of the map files for e4 are currently under releng, and the map files will tell you exactly where everything is coming from.

In this case, /releng/org.eclipse.e4.ui.releng/maps/ui.map:
feature@org.eclipse.e4.master=v20101155,:pserver:anonymous@dev.eclipse.org:/cvsroot/eclipse,,e4/org.eclipse.e4.ui/features/org.eclipse.e4.master


PW

Comment 5 Dimitar Georgiev

2010-11-30 08:33:26 EST

Thanks!

I guess I was not able to find it myself because of the 'ui' part, it's a bit confusing.

@Marti, this means the very eclipse feature is e4/org.eclipse.e4.ui/features/org.eclipse.e4.master. Since Andrew will help us this time, it's for our info right now.

Comment 6 Dimitar Georgiev

2010-11-30 08:34:53 EST

(In reply to comment #5)
> Thanks!
> 
> I guess I was not able to find it myself because of the 'ui' part, it's a bit
> confusing.
> 
> @Marti, this means the very eclipse feature is
> e4/org.eclipse.e4.ui/features/org.eclipse.e4.master. Since Andrew will help us
> this time, it's for our info right now.

Sorry guys, complete spam. I wrote what Paul already wrote at the end of the reply.

Comment 7 Martina Galabova

2010-12-01 08:16:56 EST

Hi,

 New feature IDs are pushed to the central repository. Also I've created a new 'master' build feature that includes the productive feature and the example feature.

Cheers, 
Martina