Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331363

Summary:	[Build] Spring-clean in BuildManager
Product:	[Eclipse Project] Platform	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Resources	Assignee:	Platform-Resources-Inbox <platform-resources-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	jamesblackburn+eclipse, john.arthorne
Version:	3.7
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:

Description Szymon Brandys

2010-11-29 12:29:52 EST

While working on BuildConfigurations nad Context, we noticed with James that BuildManager is far too complicated for what it does. 
The first think is the number of various basicBuild methods. Let's try to look at later in the 3.7 cycle.

Comment 1 John Arthorne

2013-03-12 09:11:33 EDT

I think BuildManager does exactly what it needs to do, and no more :) Smaller methods could be inlined to make bigger methods but I don't think it buys much benefit. This is worth revisiting only if we start doing more new feature work in here.

Comment 2 Szymon Brandys

2013-03-13 10:33:13 EDT

(In reply to comment #1)
> I think BuildManager does exactly what it needs to do, and no more :)
> Smaller methods could be inlined to make bigger methods but I don't think it
> buys much benefit. This is worth revisiting only if we start doing more new
> feature work in here.

True.