Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331338

Summary:	Java discoverer Benchmark test fails
Product:	[Modeling] MoDisco	Reporter:	Stephane Rousseau <srousseau>
Component:	Main	Assignee:	Fabien Giquel <fabien.giquel>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	fabien.giquel, gdupe, modisco.web-inbox
Version:	0.9.0	Flags:	gdupe: indigo+
Target Milestone:	0.9.0 M7
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Stephane Rousseau

2010-11-29 08:40:49 EST

Hello,

Running the benchmark with Modisco 0.9.0 and Eclipse 3.7 on class JavaDiscovererBenchmarkTest fails with a NPE error :

!ENTRY org.eclipse.gmt.modisco.java.discoverer 4 0 2010-11-26 15:58:01.866
!MESSAGE java.lang.NullPointerException (org.eclipse.gmt.modisco.java.discoverer_0.9.0.v201011240900)
!STACK 0
java.lang.NullPointerException
	at org.eclipse.gmt.modisco.java.nousages.impl.TypeImpl.eInverseAdd(TypeImpl.java:97)
	at org.eclipse.emf.ecore.impl.BasicEObjectImpl.eInverseAdd(BasicEObjectImpl.java:1415)
	at org.eclipse.gmt.modisco.java.nousages.impl.TypeAccessImpl.setType(TypeAccessImpl.java:139)
	at org.eclipse.gmt.modisco.java.io.java.JDTVisitor.endVisit(JDTVisitor.java:1944)
	at org.eclipse.jdt.core.dom.PrimitiveType.accept0(PrimitiveType.java:259)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:2482)
	at org.eclipse.jdt.core.dom.ASTNode.acceptChild(ASTNode.java:2530)
	at org.eclipse.jdt.core.dom.MethodDeclaration.accept0(MethodDeclaration.java:498)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:2482)
	at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java:2553)
	at org.eclipse.jdt.core.dom.TypeDeclaration.accept0(TypeDeclaration.java:484)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:2482)
	at org.eclipse.jdt.core.dom.ASTNode.acceptChildren(ASTNode.java:2553)
	at org.eclipse.jdt.core.dom.CompilationUnit.accept0(CompilationUnit.java:219)
	at org.eclipse.jdt.core.dom.ASTNode.accept(ASTNode.java:2482)
	at org.eclipse.gmt.modisco.java.io.java.JavaReader.visitCompilationUnit(JavaReader.java:442)
	at org.eclipse.gmt.modisco.java.io.java.JavaReader.parseTypeRoot(JavaReader.java:399)
	at org.eclipse.gmt.modisco.java.discoverer.benchmark.emfstat.JavaReaderEMFStat.parseTypeRoot(JavaReaderEMFStat.java:70)
	at org.eclipse.gmt.modisco.java.io.java.JavaReader.parsePackage(JavaReader.java:424)
	at org.eclipse.gmt.modisco.java.discoverer.benchmark.emfstat.JavaReaderEMFStat.parsePackage(JavaReaderEMFStat.java:61)
	at org.eclipse.gmt.modisco.java.io.java.JavaReader.readModel(JavaReader.java:297)
	at org.eclipse.gmt.modisco.java.io.java.JavaReader.readModel(JavaReader.java:261)
	at org.eclipse.gmt.modisco.java.discoverer.benchmark.emfstat.JavaReaderEMFStat.readModel(JavaReaderEMFStat.java:47)
	at org.eclipse.gmt.modisco.java.internal.actions.DiscoverSimpleJavaModelFromJavaProject$1.run(DiscoverSimpleJavaModelFromJavaProject.java:109)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Comment 1 Fabien Giquel

2010-11-29 13:02:24 EST

A first fix step has been commited intos SVN on modisco.java.nousages and nousages.cdo

Comment 2 Gregoire Dupe

2011-05-18 05:13:01 EDT

Hello,

I’ve launched the memory behavior benchmark on the plug-in project org.apache.commons.codec.

I did not get any error in the log and the report has been correctly generated (except the diagram generation but this is another issue).
I’ve us the version 0.9.0.v201105171434.

Regards,
Gregoire Dupe

Comment 3 Gregoire Dupe

2011-05-18 05:45:29 EDT

Hello,

The unit test org.eclipse.modisco.java.discoverer.benchmark.tests.JavaDiscovererBenchmarkTest.test001() runs properly on my computer (without any error or warning message in the log).

I assume that we can then mark the bug as closed.

Regards,
Gregoire Dupe