Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331320

Summary:

[navigation] Open Return Type hyperlink should not show up when return type is void

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Text

Assignee:

Raksha Vasisht <raksha.vasisht>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, rthakkar

Version:

3.7

Target Milestone:

3.7 M4

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Markus Keller

2010-11-29 06:23:04 EST

HEAD

I know we settled to the current solution in bug 88434, but in daily usage, I find it confusing that the "Open Return Type" hyperlink shows up when the return type is void (especially on a method declaration where I want to jump to the implementation).

Could we disable the hyperlink for primitive and void return types?

Comment 1 Dani Megert

2010-11-29 08:21:59 EST

I agree.

Comment 2 Raksha Vasisht

2010-12-06 02:25:23 EST

Created attachment 184575 [details]
Patch

Comment 3 Raksha Vasisht

2010-12-06 02:25:50 EST

(In reply to comment #2)
> Created an attachment (id=184575) [details] [diff]
> Patch

Committed to HEAD.

Comment 4 Markus Keller

2010-12-06 05:04:49 EST

In HEAD, I made the check in JavaElementHyperlinkReturnTypeDetector more efficient and made it work for primitive arrays too.

Comment 5 Rajesh

2010-12-07 08:25:58 EST

Verified for 3.7M4 with I20101206-1800.

Comment 6 Dani Megert

2010-12-07 09:13:33 EST

(In reply to comment #5)
> Verified for 3.7M4 with I20101206-1800.