Bugzilla – Full Text Bug Listing
| Summary: | Eclipse Virgo failed to shutdown after admin password change | ||
|---|---|---|---|
| Product: | [RT] Virgo | Reporter: | Krešimir Jurasović <kresimir.jurasovic> |
| Component: | virgo-build | Assignee: | Glyn Normington <glyn.normington> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | allahamit, eclipse, glyn.normington, kresimir.jurasovic, zteve.powell |
| Version: | 2.1.0.RELEASE | Keywords: | helpwanted |
| Target Milestone: | 3.0.0.M01 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Krešimir Jurasović
Thanks for raising this. I'll add it to our backlog, but we are rather busy with a Virgo F2F meeting and some tooling donation work, so it will take a while to percolate to the top. Flagging as helpwanted for anyone who fancies a piece of detective work. Ok I did some detective work and figured out why this is happening. Not sure about the right solution. I took a look at the shutdown script and the code for ShutdownClient and ShutdownCommandParser classes. The ShutdownClient uses ShutdownCommandParser to parse the arguments given to the client. Expected arguments are among others username and password. When I checked the shutdown script and the dmk stop command thoose parameters should be given in dmk.bat here set SHUTDOWN_PARMS=%SHUTDOWN_PARMS% org.eclipse.virgo.kernel.shutdown.ShutdownClient set SHUTDOWN_PARMS=%SHUTDOWN_PARMS% %OTHER_ARGS% but the %OTHER_ARGS% are not given i.e ""; The temporary solution is to give thoose parameters to the shutdown.bat script like this: shutdown.bat -username <username> -password <password>. But for me it would be alot better if this is read from the org.eclipse.virgo.kernel.users.properties where the password is actually changed othervise the password would have to be change on two seperate places. Kreso Kreso,
I guess you have already found the solution for it. You will need to specify the username/password while trying to shutdown if you have changed the username/password in 'com.springsource.kernel.users.properties' configuration.
The reason is that, the ShutdownCommand implementation has a default value of username/password as 'admin/springsource'. So, till the time you do not change the authentication config, the shutdown works. If you change it, you have to specify the username/password while shutting down, otherwise it is defaulted to 'admin/springsource' which will not work.
Take a look at the following code -
Bundle: $SERVER_HOME/lib/org.springsource.kernel.shutdown-2.x.x.jar
Package: com.springsource.kernel.shutdown
Class: ShutdownCommand.java
Code Snippet: private String password = "springsource";
private String username = "admin";
I believe it was designed that way. There can be multiple users you can configure and so the shutdown may want know, who is the user trying to shutdown the container. In that case, the shutdown client must ask you the username/password.
I am in the process of changing the shutdown client code so that it takes default values for the user and password from the config/com.springsource.kernel.users.properties, so the shutdown script will cope with a change of user and/or password without having to specify them explicitly. Fixed so that the user and password are taken from the configuration file com.springsource.kernel.users.properties and no longer need passing on the shutdown command. |