Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331259

Summary:

[Compatibility] 3.x commands no longer have states available to them

Product:

[Eclipse Project] e4

Reporter:

Remy Suen <remy.suen>

Component:

Assignee:

Paul Webster <pwebster>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Lars.Vogel, pwebster

Version:

1.0

Target Milestone:

4.1 M4

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

331240

Attachments:

Description	Flags
Fix command parameters and command state	none

Description Remy Suen

2010-11-26 18:09:17 EST

A large majority of the EGit views will not work because it can't initialize a RepositoriesViewContentProvider as the Command is returning null for getState(String).

Caused by the changes to CommandPersistence for bug 329646.

java.lang.NullPointerException
    at
org.eclipse.egit.ui.internal.repository.RepositoriesViewContentProvider.<init>(RepositoriesViewContentProvider.java:87)
    at
org.eclipse.egit.ui.internal.clone.GitSelectRepositoryPage.createControl(GitSelectRepositoryPage.java:96)
    at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:170)

Comment 1 Remy Suen

2010-11-29 08:19:19 EST

For referencing purposes, here is the code in question.
http://egit.eclipse.org/w/?p=egit.git;a=blob;f=org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesViewContentProvider.java;h=10d7746c90516d4c3c725a0c79f8de5a61647ede;hb=82ad8027cc039abe7de878110b562ca6ee97e2c9

Comment 2 Paul Webster

2010-11-29 11:41:52 EST

Created attachment 184053 [details]
Fix command parameters and command state

Comment 3 Paul Webster

2010-11-29 11:43:09 EST

Fill in the model with as much information as it can handle.  Then in the compatibility layer, add extra information that the Compay layer needs.

Released
PW