Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331248

Summary:

Open In browser uses different enablement checks for editor and context menu

Product:

z_Archived

Reporter:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

thomas.ehrnhoefer

Version:

unspecified

Target Milestone:

3.5

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
patch	thomas.ehrnhoefer: review?
mylyn/context/zip	none
fix	none
mylyn/context/zip	none

Description Thomas Ehrnhoefer

2010-11-26 16:21:03 EST

Editor seems to do a connector.getTaskUrl() call, whereas the context menu of the task list uses task.getUrl(), thus requiring a taskAttribute to be set.

I think they should both do the same check, as if e.g. the task does not contain the Url, the open in browser works in the editor, but not in the context menu, which is confusing.

I would vote for not using task.getUrl, as the connector.getTaskUrl() needs to be called in various places anyway, thus being there already. Or could that be too expensive? Maybe a double-check, first task.getUrl(), if not set, connector.getTaskUrl(), but for both occurrences the same

Comment 1 Thomas Ehrnhoefer

2010-11-26 16:34:13 EST

Created attachment 183962 [details]
patch

This patch check task.getUrl and then connector.getAuthenticatedUrl. Also added the isValidUrl check to the editor action

Comment 2 Thomas Ehrnhoefer

2010-11-26 16:34:14 EST

Created attachment 183963 [details]
mylyn/context/zip

Comment 3 Steffen Pingel

2010-12-09 12:25:54 EST

Created attachment 184875 [details]
fix

Comment 4 Steffen Pingel

2010-12-09 12:26:08 EST

Created attachment 184876 [details]
mylyn/context/zip

Comment 5 Steffen Pingel

2010-12-09 12:27:23 EST

Thanks for pointing this out. We should have a single action that handles enablement and execution. Thomas, please verify that the committed changes works as expected.

Comment 6 Thomas Ehrnhoefer

2010-12-09 13:37:01 EST

Thanks Steffen, works as expected