Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331059

Summary: PDE projects have incorrect ACLs
Product: Community Reporter: John Arthorne <john.arthorne>
Component: ServersAssignee: Eclipse Webmaster <webmaster>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: john.arthorne, Michael_Rennie
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
heres the patch in question none

Description John Arthorne CLA 2010-11-24 15:34:08 EST 
During the eclipse project Unix ACL cleanup, the PDE source code did not get applied to the correct groups. This happened because PDE actually moved all their projects under a single directory in /cvsroot/eclipse/pde/. The PDE projects that remain at the top level of /cvsroot/eclipse are legacy and existing only for the purpose of supporting old builds. As such my breakdown of projects to groups didn't correctly list the PDE projects. Currently all active PDE source code has been mapped to the "eclipse.pde" group. This means certain PDE committers do not have commit rights to their source code.

johna@dev1:/cvsroot/eclipse/pde> ls -al
total 23
drwxrwsr-x+  10 caniszczyk eclipse.pde   264 2009-08-07 11:13 .
drwxrwsr-x+ 459 root       cvs         21760 2010-11-22 10:10 ..
drwxrwsr-x+  27 caniszczyk eclipse.pde  1592 2009-01-21 09:54 apitools
drwxrwsr-x+   7 caniszczyk eclipse.pde   296 2010-11-12 13:59 build
drwxrwsr-x+   3 caniszczyk eclipse.pde    88 2008-11-12 09:29 doc
drwxrwsr-x+   5 caniszczyk eclipse.pde   168 2008-11-12 09:25 ds
drwxrwsr-x+   2 caniszczyk eclipse.pde   256 2009-09-17 13:25 org.eclipse.pde.releng
drwxrwsr-x+   5 caniszczyk eclipse.pde   168 2008-11-30 15:39 ua
drwxrwsr-x+  11 caniszczyk eclipse.pde   424 2009-09-16 12:44 ui
drwxrwsr-x+   5 caniszczyk eclipse.pde   208 2009-08-07 14:43 visualization


Here is the ACL mapping for these directories under /cvsroot/eclipse/pde:

apitools -> eclipse.pde.ui
build -> eclipse.pde.build
doc -> eclipse.pde.build, eclipse.pde.ui 
ds -> eclipse.pde.ui
org.eclipse.pde.releng -> eclipse.pde
ua -> eclipse.pde.ui
ui -> eclipse.pde.ui
visualization -> eclipse.pde.incubator
Comment 1 Eclipse Webmaster CLA 2010-11-24 16:27:55 EST 
Done.  People may need to restart their SSH connections for the changes to be visible.

-M.
Comment 2 John Arthorne CLA 2010-11-24 16:52:49 EST 
Looks good to me. Thanks!
Comment 3 Michael Rennie CLA 2010-11-25 11:30:25 EST 
not sure is this is related or a symptom. Trying to commit some new tests for API tools results in the following exceptions (one for every new folder in the patch):

org.eclipse.pde.api.tools.tests: cvs commit: ERROR: cannot write file /cvsroot/eclipse/pde/apitools/org.eclipse.pde.api.tools.tests/tests-deltas/interface/test41/resources/before/.api_description,v: No such file or directory
Comment 4 Michael Rennie CLA 2010-11-25 11:44:24 EST 
Created attachment 183868 [details]
heres the patch in question

The patch that causes the exceptions when trying to commit
Comment 5 Michael Rennie CLA 2010-11-25 11:45:25 EST 
reopening me (and possibly others) cannot commit to API tools tests
Comment 6 Eclipse Webmaster CLA 2010-11-25 11:48:26 EST 
Well the permissions look ok:

drwxrwsr-x+  41 oliviert eclipse.pde.ui  984 Jun 22  2009 interface

/cvsroot/eclipse/pde/apitools/org.eclipse.pde.api.tools.tests/tests-deltas #getfacl interface/
# file: interface/
# owner: oliviert
# group: eclipse.pde.ui
user::rwx
group::rwx
mask::rwx
other::r-x
default:user::rwx
default:group::rwx
default:mask::rwx
default:other::r-x

But I don't see the directory your trying to commit to:

/cvsroot/eclipse/pde/apitools/org.eclipse.pde.api.tools.tests/tests-deltas/interface #ls -Fla test41
/bin/ls: test41: No such file or directory

Did you 'restart' Eclipse between the changes I made and this commit?

-M.
Comment 7 Michael Rennie CLA 2010-11-25 11:53:36 EST 
(In reply to comment #6)
> 
> Did you 'restart' Eclipse between the changes I made and this commit?

Yes.
Comment 8 Michael Rennie CLA 2010-11-25 12:04:38 EST 
I just got olivier to commit the test patch, so it would seem only I have am having problems...
Comment 9 Eclipse Webmaster CLA 2010-11-25 12:38:17 EST 
Well you have permission to create in that directory:

mrennie@/cvsroot/eclipse/pde/apitools/org.eclipse.pde.api.tools.tests/tests-deltas/interface> mkdir t
mrennie@/cvsroot/eclipse/pde/apitools/org.eclipse.pde.api.tools.tests/tests-deltas/interface> ls -Fla | grep t
total 1

drwxrwsr-x+  2 mrennie  eclipse.pde.ui   48 2010-11-25 12:35 t/

-M.
Comment 10 Michael Rennie CLA 2010-11-25 14:51:38 EST 
I just rebooted my machine and now I can commit to API tools.

re-closing, not sure why it needed a reboot.
Comment 11 Denis Roy CLA 2010-11-25 20:52:31 EST 
> re-closing, not sure why it needed a reboot.

Windows?
Comment 12 Michael Rennie CLA 2010-11-26 10:09:29 EST 
(In reply to comment #11)
> > re-closing, not sure why it needed a reboot.
> 
> Windows?

Ubuntu 10.10