Bugzilla – Full Text Bug Listing
| Summary: | Approve and include dependencies for the tests | ||
|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Paul Webster <pwebster> |
| Component: | Search | Assignee: | Project Inbox <e4.search-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | aniefer, danail.branekov, dimitar.georgiev |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Paul Webster
Some interesting technical info, after I managed to compile the tests locally today: 1. The search console tests need have to have a dependency to only these bundles from the abbot distrubution: abbot.swt.eclipse abbot.swt However, there is a wrongly declared - plugin to plugin dependency from org.eclipse.platform.discovery.test.testutils to abbot.swt.hierarchy - feature to plugin dependency from org.eclipse.platform.discovery_tests.feature to abbot.swt.hierarchy These are not used and will be removed. We specifically want to prevent dependency from search console tests to abbot.swt.hierarchy and abbot.swt.gef because they both need org.eclipse.emf. Hence our test target platform would become bigger than the real one needed, which is unwanted. 2. The org.eclipse.platform.discovery_tests.feature wrongly includes org.jmock plugin inside it. I guess search console tests have no business packing jmock inside them. This will be removed. 3. All the test plugins of search console fail to bin-include /OSGI-INF in their build.properties. I know this is not really related to this bugzilla, but I want to fix it anyway, so we don't get any build warnings when we're eventually able to build the tests. I will make a commit and fix the three described problems (probably tomorrow) I guess what is described above is prep work for "Approve and include dependencies for the tests", so do you think it is OK to submit with this bugzilla, or should i rather create one for the dependencies and one for the bin-include? Cheers, Dimitar (In reply to comment #1) > I guess what is described above is prep work for "Approve and include > dependencies for the tests", so do you think it is OK to submit with this > bugzilla, or should i rather create one for the dependencies and one for the > bin-include? I intended this bug to be "Get the initial contribution into the starting shape we need" so I think it is fine to use this bug. May as well do the fixes in our SCM rather than trying to get it 100% before we even start :-) PW The problems described above have been removed with http://git.eclipse.org/c/e4/org.eclipse.e4.search.git/commit/?id=e3b8431ac85d17941ed2d6a881eace9baec0c11b and integrated in the map I was browsing in the webtools project today and found out that on its download page there is a new (at least for me) link called "Eclipse Test Framework (required only for Automated JUnit tests)" - id: org.eclipse.test. It contains easymock, performance test framework, ant stuff, junit and hamcrest. I guess that we should get jmock and abbot there as well. What do you think? Shane, I am putting you in the CC list. If we get JMock into the org.eclipse.test feature, then we should probably get it out from org.eclipse.jst.ws.jaxws.dom_tests.feature Danail The UI tests have been reimplemented in SWTBot and dependencies to Abbot have been removed. org.jmock is already available in Orbit Paul, we can now include the tests in the build. Could you give some pointers how to do that? Thanks! Regards, Danail The tests are already part of the test run. Closing |