Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 331004

Summary: Missing artifacts after aggregate, works with director application
Product: [Technology] CBI Reporter: Marco Lehmann-Mörz <mlehmannm>
Component: CBI p2 Repository AggregatorAssignee: Project Inbox <b3.aggregator-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pascal, thomas
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
B3 aggregator model
none
B3 aggregator model (de+fr)
none
log of the run with the updated model
none
directory listing of the run with the updated model
none
fix for odd behaviour on second run thomas: iplog+

Description Marco Lehmann-Mörz CLA 2010-11-24 07:02:37 EST
Build Identifier: org.eclipse.b3.aggregator / 0.1.0.r01227 org.eclipse.b3.aggregator.engine / 0.1.0.r01404 org.eclipse.b3.aggregator.engine.maven / 0.1.0.r01047 org.eclipse.b3.aggregator.legacy / 0.1.0.r01087 org.eclipse.b3.cli / 0.1.0.r01050 org.eclipse.b3.p2 / 0.1.0.r01244 org.eclipse.b3.p2.maven / 0.1.0.r01234 org.eclipse.b3.util / 0.1.0.r01290

When I use the attached B3 aggregator model to aggregate some pieces from eclipse.org, the german nl-fragment for org.eclipse.draw2d (org.eclipse.draw2d.nl_de/3.5.0) is missing. When I use the p2 director to do the same everything is there. B3 doesn't say anything about dropping that nl-fragment, even with log level DEBUG.

Reproducible: Always
Comment 1 Marco Lehmann-Mörz CLA 2010-11-24 07:03:53 EST
Created attachment 183741 [details]
B3 aggregator model
Comment 2 Thomas Hallgren CLA 2010-11-24 08:00:34 EST
Are you using the director on a platform where nl_de is the default or are you're passing this info as a -p2.nl nl_de on the command line? I don't think the director would include that fragment otherwise.

I think we need to extend the 'configuration' entity of the aggregator model to include the nl segement. Either that or somehow persuade the p2 planner to include all language variants. Not sure how to do that though since the nl=xxx is in the same filter as os, ws, and arch. AFAIK, there's no way to have this filter return true unless the nl setting is an exact match.

CC'ing Pascal since I think this highlights a general p2 question. Is there anyway to make the planner include all language fragments?
Comment 3 Marco Lehmann-Mörz CLA 2010-11-24 09:12:16 EST
It is indeed a english Windows PC with a german localisation package, but I don't think that's the problem. I will verify that with NL=fr.

Just to clarify:
The german nl-fragments from the babel helios repository are there. Only the german nl-fragment for org.eclipse.draw2d is missing because it comes from the babel galileo repository. When I disable the helios repository, all nl-fragments are there.
The feature org.eclipse.babel.nls_tools.gef_de_3.5.0.v20100814074441.jar has been aggregated via B3. The nl-fragment org.eclipse.draw2d.nl_de_3.5.0.v20100814074441.jar is referenced from there. So B3 (or some underlying technology) seems to drop that bundle.
Comment 4 Marco Lehmann-Mörz CLA 2010-11-24 16:49:33 EST
Created attachment 183804 [details]
B3 aggregator model (de+fr)
Comment 5 Marco Lehmann-Mörz CLA 2010-11-24 16:50:46 EST
Created attachment 183805 [details]
log of the run with the updated model
Comment 6 Marco Lehmann-Mörz CLA 2010-11-24 16:55:03 EST
Created attachment 183806 [details]
directory listing of the run with the updated model
Comment 7 Marco Lehmann-Mörz CLA 2010-11-24 16:58:57 EST
I've got no idea what happens here. All nl-fragments come solely from the babel galileo repository. NL-features from both babel (helios , galileo) are there.
The german nl-fragment for org.eclipse.draw2d is still missing, but the french one is there. For other bundles the german nl-fragment is there. Why?
Comment 8 Marco Lehmann-Mörz CLA 2010-11-25 07:50:13 EST
Created attachment 183847 [details]
fix for odd behaviour on second run

After the first run I always get a message like "Unable to move ..." and B3 quits.
It seems there is a check missing in MirrorGenerator.
Please review.
Comment 9 Thomas Hallgren CLA 2010-11-25 08:01:28 EST
I don't understand. How is this fix related to the missing artifacts?
Comment 10 Marco Lehmann-Mörz CLA 2010-11-25 08:05:52 EST
(In reply to comment #9)
> I don't understand. How is this fix related to the missing artifacts?

Sorry, there is no relation. It bugged my while testing this problem with french.
Comment 11 Marco Lehmann-Mörz CLA 2010-12-16 08:52:02 EST
(In reply to comment #8)
> Created an attachment (id=183847) [details]
> fix for odd behaviour on second run
> 
> After the first run I always get a message like "Unable to move ..." and B3
> quits.
> It seems there is a check missing in MirrorGenerator.
> Please review.

Please review and apply the patch. I cannot aggregate multiple times. This is necessary due the internal network problems.
Comment 12 Marco Lehmann-Mörz CLA 2011-02-15 02:30:40 EST
Comment on attachment 183847 [details]
fix for odd behaviour on second run

Can you apply the patch, please!!!
Comment 13 Thomas Hallgren CLA 2011-02-15 02:47:33 EST
Patch applied to trunk, rev 1418.

Thanks, and sorry for the delay.
Comment 14 David Williams CLA 2016-09-16 15:57:34 EDT
[Bookkeeping change only. Moving bugs to the new "home" of aggregator, CBI.
No change to assignee for resolved and verified bugs.]