Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330989

Summary:

[dstore] OutOfMemoryError occurs when searching for a text in a large remote file

Product:

[Tools] Target Management

Reporter:

Masao Nishimoto <e03616>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

dmcknigh

Version:

unspecified

Target Milestone:

3.3 M4

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

331366, 331367

Attachments:

Description	Flags
patch to not read large file all at once	none

Description Masao Nishimoto

2010-11-24 00:31:44 EST

UniversalSearchHandler.simpleSearch() tries to read all at once.  If the file size is more than the half of free heap size, it always causes the OutOfMemory.

Comment 1 David McKnight

2010-11-24 09:32:41 EST

Created attachment 183759 [details]
patch to not read large file all at once

Comment 2 David McKnight

2010-11-24 09:33:20 EST

Masao, could you try this patch?

Comment 3 Masao Nishimoto

2010-11-24 19:48:15 EST

I tested the patch, and confirmed that no OutOfMemoryError occurred.

Comment 4 David McKnight

2010-11-25 09:37:23 EST

I've committed the change to cvs.  Does this need to be backported?

Comment 5 Masao Nishimoto

2010-11-25 19:11:37 EST

Yes, please back port to 3.0.3 and 3.2.