Bugzilla – Full Text Bug Listing
| Summary: | The method signature changed in org.eclipse.birt.report.engine.api.HTMLRenderContext | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Samuel Wu <samwu> | ||||
| Component: | TPTP | Assignee: | Bozier jerome <jerome.bozier> | ||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | kathy, paulslau | ||||
| Version: | unspecified | Flags: | paulslau:
review+
|
||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 183687 [details]
patch
this patch follow BIRT api change :
. update Manifest file in org.eclipse.tptp.platform.report.birt
. update Manifest file in org.eclipse.hyades.ui
(needed because they refactored core and there is an indirect dependency on birt.core now)
. fix call in BirtReportGenerator since they have changed method name in HTMLRenderContext.java
updating worked hours (most = find minimal birt plugins to have a workspace that compile) Paul, could you review this small patch please ? it avoid build to be performed many thanks in advance, Jerome Reviewed and approved with comments: -Change 5.0.0) back to 3.0.0) in the updated manifest.mf files. -Open a blocking defect again the BIRT project since they broke API and change dependencies in a service release. Hi, Jerome Is this patch checked into cvs yet? Sam i have let V5.0 in some manifest lines (org.eclipse.birt.core and org.eclipse.birt.report.model) else it would not compile, i returned to V3.0 for org.eclipse.birt.report.engine as it was only raising a warning patch checked under CVS now closing (In reply to comment #5) > i have let V5.0 in some manifest lines (org.eclipse.birt.core and > org.eclipse.birt.report.model) else it would not compile, i returned to V3.0 > for org.eclipse.birt.report.engine as it was only raising a warning > > patch checked under CVS now > > closing Thanks. Could you open a blocking defect again the BIRT project since they broke API and change dependencies in a service release. filed a BIRT bugzilla : https://bugs.eclipse.org/bugs/show_bug.cgi?id=331128 Closing (In reply to comment #7) > filed a BIRT bugzilla : > https://bugs.eclipse.org/bugs/show_bug.cgi?id=331128 Note, the BIRT Team decided to roll-back their API-breaking change (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=331128#c2) so we may need to reopen this defect to handle the change on the TPTP side. (In reply to comment #9) > (In reply to comment #7) > > filed a BIRT bugzilla : > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=331128 > > Note, the BIRT Team decided to roll-back their API-breaking change (see > https://bugs.eclipse.org/bugs/show_bug.cgi?id=331128#c2) so we may need to > reopen this defect to handle the change on the TPTP side. Reopen the defect. The method name has set back to renderContext.setRenderOption(options); Closing. |
Here is the error log we have: [javac] 17. ERROR in /tmp/workspace/plugins/org.eclipse.tptp.platform.report.birt/src/org/eclipse/tptp/platform/report/birt/core/provisional/BIRTReportGenerator.java (at line 270) [javac] renderContext.SetRenderOption(options); [javac] ^^^^^^^^^^^^^^^ [javac] The method SetRenderOption(HTMLRenderOption) is undefined for the type TPTPHTMLRenderContext I am guessing that the method name is supppose to be setRenderOption(options)