Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330935

Summary:	plugin.xml compiler should bark when class doesn't extend/implement the "basedOn" type
Product:	[Eclipse Project] PDE	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	PDE-UI-Inbox <pde-ui-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	pwebster
Version:	3.7
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:	stalebug

Description Markus Keller

2010-11-23 10:59:18 EST

When I apply the patch from bug 36939 comment 70 to HEAD of org.eclipse.jdt.core and org.eclipse.jdt.core.tests.model, I'd expect an problem in org.eclipse.jdt.core.tests.model/plugin.xml: The file contains:

   <extension point="org.eclipse.jdt.core.compilationUnitProvider">
       <compilationUnitProvider file-extensions="foo"
           class="org.eclipse.jdt.core.tests.model.TestFooCompilationUnitProvider"/>
   </extension>

The class only implements ICompilationUnitProvider, but the declaration in compilationUnitProvider.exsd says:

         <attribute name="class" type="string" use="required">
            <annotation>
               <documentation>
                  the class that implements this container initializer.
         This class must implement a public subclass of &lt;code&gt;org.eclipse.jdt.core.ClasspathContainerInitializer&lt;/code&gt; with a public 0-argument constructor.
               </documentation>
               <appInfo>
                  <meta.attribute kind="java" basedOn="org.eclipse.jdt.core.ClasspathContainerInitializer"/>
               </appInfo>
            </annotation>
         </attribute> 

=> The "basedOn" attribute is set to ClasspathContainerInitializer.
=> TestFooCompilationUnitProvider doesn't extends that class, so there's a bug in the patch, but our tooling didn't detect it.

Bug 225121 sounds similar to this, but in N20101121-2000, I couldn't even get *any* problem for this.

Comment 1 Eclipse Webmaster

2019-09-06 15:37:39 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 2 Julian Honnen

2019-09-09 02:38:10 EDT

Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.