Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330875

Summary: Use of Parenthesis in Stack Frame Name
Product: [Tools] CDT Reporter: Ken Ryall <ken.ryall>
Component: cdt-debug-dsfAssignee: Ken Ryall <ken.ryall>
Status: RESOLVED FIXED QA Contact: Pawel Piech <pawel.1.piech>
Severity: normal    
Priority: P3 CC: cdtdoug, marc.khouzam
Version: 7.0Flags: marc.khouzam: review+
Target Milestone: 8.0   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
don't double parens ken.ryall: iplog-

Description Ken Ryall CLA 2010-11-23 00:21:44 EST 
Created attachment 183628 [details]
don't double parens

StackFrameVMNode's label provider adds "()" at the end of the function name for a stack frame. This is handy unless the function name provided already includes parenthesis. This can happen when the function name includes the full C++ function signature as in:

CActiveScheduler::Start(CActiveScheduler::TLoop**)

Currently you end up with:

CActiveScheduler::Start(CActiveScheduler::TLoop**)()

This patch continues the existing behavior by default but skips adding the "()" if the function name already contains "("

I would like to fix this for 7.0.x and 8.0, the 7.0.x patch will be slightly different because MessagesForLaunchVM.properties was renamed.
Comment 1 Marc Khouzam CLA 2010-11-23 15:14:59 EST 
Looks good to me
Comment 3 Ken Ryall CLA 2011-01-13 08:23:42 EST 
Committed to both branches.