Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330867

Summary: EE package includes PDE indirectly, but should be direct
Product: [Technology] EPP Reporter: Jeff McAffer <jeffmcaffer>
Component: jee-packageAssignee: Project Inbox <epp.packager-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: david_williams, mknauer, nathan
Version: unspecified   
Target Milestone: 1.3.0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
patch to had pde feature explicitly none

Description Jeff McAffer CLA 2010-11-22 17:16:02 EST
Seems that in SR1 the EE package actually includes the PDE bundles but the official declaration [0] does not list it.  Personally I would say that EE developers don't need PDE though perhaps in the future they will...

[0] http://www.eclipse.org/downloads/packages/eclipse-ide-java-ee-developers/heliossr1
Comment 1 David Williams CLA 2010-11-22 17:33:51 EST
Yes, it's supposed to be there, by popular demand  ... with its "capability" turned off by default. See bug 277394. 

So, lets use this bug to say the web document is wrong. Not sure where that comes from our EPP package XML file? Or hand created?
Comment 2 Markus Knauer CLA 2010-11-22 17:50:57 EST
(In reply to comment #1)
> So, lets use this bug to say the web document is wrong. Not sure where that
> comes from our EPP package XML file? Or hand created?

Are we talking about http://www.eclipse.org/downloads/packages/eclipse-ide-java-ee-developers/heliossr1 (generated from the feature.xml) or about http://www.eclipse.org/downloads/compare.php (hand-crafted)?
Comment 3 David Williams CLA 2010-11-22 18:06:46 EST
The former. Looks like this is "our" bug after all. I check the feature.xml, and looks like we never did explicitly add the pde feature, and just relied on "picking it up" from the datatools "hard" requirement on it. 

So ... it's probably "incomplete". Not including all PDE bundles, as we intended. I've not looked to see what's missing ... API Tools? ... but I think we should add 

org.eclipse.pde 

in the list of features, in our feature.xml. 

Will that be disruptive in maintenance build? I don't think so ... but ... not sure I know all aspects.
Comment 4 David Williams CLA 2010-11-22 18:17:07 EST
Created attachment 183623 [details]
patch to had pde feature explicitly

Well ... good news is I guess datatools requires whole feature, so all bundles are included. But, I think "we" in JEE Package should include it. That's the intent. So, I think we can "fix" with no impact in Helios SR2 (and Indigo)..
Comment 5 David Williams CLA 2010-11-22 18:22:30 EST
Fixing title. 

And, just to explain ... while JEE Developers do not need PDE per se (currently) we decided to include it since so many users also use the package to develop plugins, as well as JEE apps (as well as Java programs, etc.) ... so that's what I meant by 'popular demand'. 

Markus, can you apply the patch to maintenance stream (and similar change to head, if it doesn't apply directly). That will make us conceptually correct, and automatically fix the feature list. It appears we did fix (by hand :) the comparison table.
Comment 6 Markus Knauer CLA 2010-11-23 02:57:57 EST
Patch applied to HELIOS branch.
Comment 7 Markus Knauer CLA 2010-11-23 03:02:53 EST
Patch applied to CVS HEAD (Indigo).
Comment 8 David Williams CLA 2011-01-01 22:26:32 EST
resolving as fixed, per previous comments.