| Summary: | EE package includes PDE indirectly, but should be direct | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] EPP | Reporter: | Jeff McAffer <jeffmcaffer> | ||||
| Component: | jee-package | Assignee: | Project Inbox <epp.packager-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david_williams, mknauer, nathan | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 1.3.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Jeff McAffer
Yes, it's supposed to be there, by popular demand ... with its "capability" turned off by default. See bug 277394. So, lets use this bug to say the web document is wrong. Not sure where that comes from our EPP package XML file? Or hand created? (In reply to comment #1) > So, lets use this bug to say the web document is wrong. Not sure where that > comes from our EPP package XML file? Or hand created? Are we talking about http://www.eclipse.org/downloads/packages/eclipse-ide-java-ee-developers/heliossr1 (generated from the feature.xml) or about http://www.eclipse.org/downloads/compare.php (hand-crafted)? The former. Looks like this is "our" bug after all. I check the feature.xml, and looks like we never did explicitly add the pde feature, and just relied on "picking it up" from the datatools "hard" requirement on it. So ... it's probably "incomplete". Not including all PDE bundles, as we intended. I've not looked to see what's missing ... API Tools? ... but I think we should add org.eclipse.pde in the list of features, in our feature.xml. Will that be disruptive in maintenance build? I don't think so ... but ... not sure I know all aspects. Created attachment 183623 [details]
patch to had pde feature explicitly
Well ... good news is I guess datatools requires whole feature, so all bundles are included. But, I think "we" in JEE Package should include it. That's the intent. So, I think we can "fix" with no impact in Helios SR2 (and Indigo)..
Fixing title. And, just to explain ... while JEE Developers do not need PDE per se (currently) we decided to include it since so many users also use the package to develop plugins, as well as JEE apps (as well as Java programs, etc.) ... so that's what I meant by 'popular demand'. Markus, can you apply the patch to maintenance stream (and similar change to head, if it doesn't apply directly). That will make us conceptually correct, and automatically fix the feature list. It appears we did fix (by hand :) the comparison table. Patch applied to HELIOS branch. Patch applied to CVS HEAD (Indigo). resolving as fixed, per previous comments. |