Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330858

Summary:

AbstractBasicTextPropertySection's TextChangeHelper doesn't handle "modify" events properly

Product:

[Modeling] GMF-Runtime

Reporter:

Wayne <wdiu>

Component:

General

Assignee:

Anthony Hunter <ahunter.eclipse>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

ahunter.eclipse

Version:

unspecified

Target Milestone:

1.4.2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch to fix the problem	ahunter.eclipse: iplog+

Description Wayne

2010-11-22 16:19:11 EST

Build Identifier: GMF 1.4.0

The "Modify" event is not handled by the listener.  Instead, it treats "Keydown" events as modification.  This is incorrect, as simply pressing the Shift key when the field has focus results in the modification flag being set.  Second, it does not treat copy / paste using the mouse as modification because it is only checking for "Keydown" events.  Attached a patch to resolve the issue.  Alex Boyko has reviewed the patch.

Reproducible: Always

Comment 1 Wayne

2010-11-22 16:19:56 EST

Created attachment 183609 [details]
Patch to fix the problem

Comment 2 Anthony Hunter

2010-11-29 12:00:30 EST

Committed to R1_4_maintenance and HEAD.