Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330847

Summary:	Poor attribute validation for API use scans
Product:	[Eclipse Project] PDE	Reporter:	Michael Rennie <Michael_Rennie>
Component:	API Tools	Assignee:	Vikas Chandra <Vikas.Chandra>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ankur_sharma, curtis.windatt.public, Vikas.Chandra
Version:	3.6
Target Milestone:	4.21 M2
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/182846 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=474a13f2aafd5db2581790cd9855dccf5ce2dd57
Whiteboard:

Description Michael Rennie

2010-11-22 14:14:13 EST

I20101116-0800

The error checking for the API use scan tab could use some work.

Steps:

1. create a new workspace and do not add an API baseline
2. create a new use scan configuration, notice the API baseline option is selected, but that the error message is complaining about the report location not being valid.
3. Type in a garbage entry like 'foo' into the report field and notice all of the errors are gone.
4. try to launch it, and watch as it blows up, complaining about no baselines

I would expect we would check:

1. what we are wanting to analyze exists
2. that the report location could actually be a file - meaning we would not check that it does exist, but that it could exist. For example entering in 'foo/xml', where would that be created? is it valid to try and create that in Windows? Linux?

Comment 1 Michael Rennie

2010-11-22 14:18:03 EST

Also if you do create a new baseline, the combo for selecting one becomes enabled [OK] but the one you created is not selected. I would expect a baseline to be selected for me once I create one - either the first one, or the default one.

Comment 2 Eclipse Genie

2019-07-08 19:38:03 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 3 Eclipse Genie

2021-06-29 13:26:32 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 4 Eclipse Genie

2021-07-07 07:50:23 EDT

New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/182846

Comment 5 Vikas Chandra

2021-07-07 07:52:50 EDT

With this change, if there is a baseline it will be selected but if the workspace has no baseline, the target would be selected.

I would expected user to select the location from UI ( so 3 wont happen). 

With this change use scan report would work the 1st time if the report location is given properly.

Comment 6 Eclipse Genie

2021-07-12 03:38:32 EDT

Gerrit change https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/182846 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=474a13f2aafd5db2581790cd9855dccf5ce2dd57

Comment 7 Vikas Chandra

2021-07-28 05:56:52 EDT

verified in 
Version: 2021-09 (4.21)
Build id: I20210727-1800