Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330840

Summary:

WTP-JUNIT_HeaderParserTests.runEAR50Test() assertions should be different for EAR with and whitout deployment descriptor.

Product:

[WebTools] WTP Java EE Tools

Reporter:

Salvador Zalapa <zalapa>

Component:

jst.j2ee

Assignee:

Salvador Zalapa <zalapa>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

jsholl

Version:

unspecified

Flags:

jsholl: review+

Target Milestone:

3.2.3

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Adding an boolean extra field and modifing some assertions.	ccc: iplog+

Description Salvador Zalapa

2010-11-22 13:54:26 EST

Build Identifier: 

In WTP test HeaderParserTests(found in org.eclipse.wtp.j2ee.headless.tests.j2ee.operations), the test testEAR50Import_NoDD is falling due to the JavaEEQuickPeek object gotten from an EAR archive version 5.0 without deployment descriptor is version 6.0 ( see org.eclipse.jst.j2ee.internal.archive.JavaEEArchiveUtilities.refine() from line 528). I think that HeaderParserTests.runEAR50Test() method should be more flexible for this issue. I suggest to add a boolean attribute to the internal class TesData to indicate if the archive has deployment descriptor and modify the method runEAR50Test() assertions regarding if the ear do have or does not deployment descriptor.   

Reproducible: Always

Comment 1 Salvador Zalapa

2010-11-22 13:56:19 EST

Created attachment 183591 [details]
Adding an boolean extra field and modifing some assertions.

Comment 2 Jason Sholl

2010-11-23 09:27:08 EST

Code checked into 32M and HEAD for WTP 3.2.3 and 3.3