Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330828

Summary:

bundleInstallArtifactTreeFactory osgi service is registered twice in kernel.deployer

Product:

[RT] Virgo

Reporter:

Dmitry Sklyut <dmitry>

Component:

unknown

Assignee:

Project Inbox <virgo-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

glyn.normington

Version:

2.2.0.M01

Target Milestone:

3.0.0.M01

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch	glyn.normington: iplog+

Description Dmitry Sklyut

2010-11-22 11:53:48 EST

Build Identifier: 2.2.0 (master branch)

Found in: kernel/org.eclipse.virgo.kernel.deployer/src/main/resources/META-INF/spring/deployer-context.xml

First registration is on line 255:
	<!--  basic artifact type factories -->
	<service
		interface="org.eclipse.virgo.kernel.install.artifact.InstallArtifactTreeFactory"
		ref="bundleInstallArtifactTreeFactory" />

Second is on line 278:
	<service ref="bundleInstallArtifactTreeFactory"
		interface="org.eclipse.virgo.kernel.install.artifact.InstallArtifactTreeFactory" />

I have not seen this to cause an issue so far.  I think one of the service registrations should be removed.

Reproducible: Always

Comment 1 Glyn Normington

2010-11-22 12:10:23 EST

Nice catch! I agree we should delete one of these service elements.

Comment 2 Dmitry Sklyut

2010-11-22 12:17:28 EST

Created attachment 183580 [details]
patch

I wrote 100% of the code and have rights to contribute this code to Eclipse

Comment 3 Glyn Normington

2010-11-23 04:35:44 EST

Thanks for the patch! Applied at commit 7c06ccd77ef17868710c90e0d3ea7988ac17b3bf and pushed.