Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330796

Summary: Tigerstripe hangs on saving project with new dependency module
Product: [Technology] Tigerstripe Reporter: Maria Kolchinskaja <mshulgina>
Component: UIAssignee: Project Inbox <tigerstripe.ui-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: nmehrega, valentin, yuri
Version: unspecified   
Target Milestone: 0.5M0   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch_1
none
Patch_2 none

Description Maria Kolchinskaja CLA 2010-11-22 08:33:50 EST 
Build Identifier: 

Tigerstripe hangs when I added Tigerstripe module as Dependency and try to save project.

Steps to reproduce:
1. Create tigerstripe project1 'project1'. Add referenced Tigerstripe project. Export project1 as a a Tigerstripe Module. 
2. Move created Tigerstripe Module file to project2. 
3. Select project2. Open tigerstripe.xml on dependencies tab. Add module to a project as dependency. Press 'save' button to save project. 
Tigerstripe hangs. 

Reproducible: Always
Comment 1 Navid Mehregani CLA 2010-11-22 09:56:13 EST 
For some reason, I can't reproduce this on my machine.  Can someone else try please?
Comment 2 Valentin Yerastov CLA 2010-11-23 07:33:14 EST 
Hi Navid,

I reproduced this bug. Here are my steps:

1. Create TS project p1
2. Create TS project p2
3. Add p2 to references of p1 
4. Export p1 as TS module
5. Copy created module jar file from p1 directory to p2 directory
6. Add copied jar to dependencies of p2.
7. Save it

At first glance - this deadlock, which occurs in 

org.eclipse.tigerstripe.workbench.internal.core.model.ArtifactManager.refresh(boolean forceReload, IProgressMonitor monitor)

at line 917: writeLock.lock();
Comment 3 Valentin Yerastov CLA 2010-11-24 03:31:03 EST 
Created attachment 183733 [details]
Patch_1

Fixed
Comment 4 Yuri Strot CLA 2010-11-29 06:38:40 EST 
Patch applied.
Comment 5 Navid Mehregani CLA 2010-11-29 16:17:22 EST 
I still get a deadlock when I follow the instruction in comment#2.  I've verified that I have the latest code and all the changes in the attached patch is in my workspace.

After following the instructions in comment#2, the workbench seems frozen for a while and then a stack overflow occurs! 

This defect can be pushed to I27 if there is no cycle to resolve it in this iteration.
Comment 6 Valentin Yerastov CLA 2010-11-30 13:18:46 EST 
Created attachment 184160 [details]
Patch_2

I fixed this problem.
Comment 7 Yuri Strot CLA 2010-12-06 09:28:25 EST 
I applied second patch from Valentin.
Comment 8 Navid Mehregani CLA 2010-12-06 16:56:32 EST 
Verified. Thanks!