Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330742

Summary: Profiling data written to outgoing socket is unbuffered
Product: z_Archived Reporter: Jonathan West <jgwest>
Component: TPTPAssignee: Jonathan West <jgwest>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: critical    
Priority: P2 CC: ernest, jcayne, jgwest, mikereid
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to Socket TL
none
Patch to SocketListener.h for Solaris 64 none

Description Jonathan West CLA 2010-11-20 13:30:45 EST 
Profiling data written to the outgoing socket, from the agent controller to the workbench, is currently unbuffered. This means that 20,000-25,000 single 100-byte messages per second are being sent out one-at-a-time, rather than together. This imposes a major performance penalty on profiling overhead and workbench processing speeds.

Fix is to wait for a certain amount of data to be available, and write it all at once, rather than writing each message separately. This also requires us to maintain a thread which ensures that data will not wait longer than a fixed amount to be sent.
Comment 1 Jonathan West CLA 2010-11-20 13:40:24 EST 
Created attachment 183524 [details]
Patch to Socket TL
Comment 2 Jonathan West CLA 2010-11-20 13:45:28 EST 
Resolving.
Comment 3 Jonathan West CLA 2010-12-07 13:34:34 EST 
Reopening
Comment 4 Jonathan West CLA 2010-12-07 13:36:03 EST 
Created attachment 184743 [details]
Patch to SocketListener.h for Solaris 64
Comment 5 Jonathan West CLA 2010-12-07 13:36:48 EST 
Patch checked into HEAD.
Comment 6 Kathy Chan CLA 2011-02-11 13:46:30 EST 
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 7 Jonathan West CLA 2011-04-01 14:24:08 EDT 
Closing.