Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330723

Summary:	RendereredToolBarRenderer leaks image
Product:	[Eclipse Project] e4	Reporter:	Bogdan Gheorghe <gheorghe>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	pwebster
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:	stalebug

Description Bogdan Gheorghe

2010-11-19 18:09:15 EST

We're leaking get view menu image.


at org.eclipse.swt.graphics.Device.new_Object(Device.java:859)
	at org.eclipse.swt.graphics.Resource.init(Resource.java:86)
	at org.eclipse.swt.graphics.Image.<init>(Image.java:492)
	at org.eclipse.e4.ui.workbench.renderers.swt.RenderedToolBarRenderer.getViewMenuImage(RenderedToolBarRenderer.java:291)
	at org.eclipse.e4.ui.workbench.renderers.swt.RenderedToolBarRenderer.addMenuButton(RenderedToolBarRenderer.java:214)
	at org.eclipse.e4.ui.workbench.renderers.swt.RenderedToolBarRenderer.postProcess(RenderedToolBarRenderer.java:185)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:493)

Comment 1 Paul Webster

2010-11-19 18:14:18 EST

My RenderedToolBarRenderer looks different than yours, but we only create the view image once for that renderer, which then lives for the life of the application.

I guess multiple applications would leak the resource every time?

PW

Comment 2 Bogdan Gheorghe

2010-11-21 23:01:37 EST

Yup, that's correct.

Comment 3 Eclipse Genie

2019-01-15 09:50:19 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 4 Lars Vogel

2019-06-05 07:40:48 EDT

This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.