| Summary: | Make tasks assigned to me more prominent in the task list | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Sam Davis <sam.davis> | ||||||||||||
| Component: | Mylyn | Assignee: | Frank Becker <eclipse> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | enhancement | ||||||||||||||
| Priority: | P2 | CC: | eclipse, steffen.pingel, tomasz.zarna | ||||||||||||
| Version: | unspecified | Keywords: | noteworthy | ||||||||||||
| Target Milestone: | 3.11 | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Windows 7 | ||||||||||||||
| Whiteboard: | sprint=1;effort=2; | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 343626 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Sam Davis
+1 for both suggestions. I am not sure though where we would put the affordance to toggle the task list filter. It may prove to be useful enough to justify a toolbar button but at the same time we have too many modes (and particularly combination of modes) already that we may want to consider this as part of revamping the presentation switcher. I agree that there are already too many modes. I so frequently switch between focussed-scheduled and unfocussed-categorized that I wish I could have 2 task lists open. Created attachment 221752 [details] screenshot 8012: 330695: indicate tasks assigned to me in the task list tooltip [I84946984] https://git.eclipse.org/r/#change,8012 Created attachment 221753 [details]
mylyn/context/zip
The icon looks good but I don't like the bold. It makes the assignee stand out too much. I create two reviews for the 2. part https://git.eclipse.org/r/9640 https://git.eclipse.org/r/9641 Created attachment 225542 [details]
mylyn/context/zip
Created attachment 231899 [details]
possible icon for focus on my tasks button
Frank, I haven't looked at the code yet, but that icon looks like it is hiding my tasks. I wonder if we should just show the person_me icon without a line through it? Or we could use the blue person icon with a line through it, or we could combine them, something like in this attachment. What do you think is best?
(In reply to comment #5) > The icon looks good but I don't like the bold. It makes the assignee stand out > too much. I agree. (In reply to comment #8) > Created attachment 231899 [details] > possible icon for focus on my tasks button > > Frank, I haven't looked at the code yet, but that icon looks like it is hiding > my tasks. I wonder if we should just show the person_me icon without a line > through it? Or we could use the blue person icon with a line through it, or we > could combine them, something like in this attachment. What do you think is > best? I like the combine icon and push a new patch set to the review. Sam or Tomasz, can you review https://git.eclipse.org/r/#/c/9640/ so that I can push an updated patch set for review https://git.eclipse.org/r/#/c/9641/ Thanks Patch Set 3 of review https://git.eclipse.org/r/#/c/9641/ include the new icon in the LocalToolBar Created attachment 236618 [details]
mylyn/context/zip
Should the 'my tasks filter' button be hidden off the tool bar when in focused mode, just like the incoming filter is hidden? And should the 2 buttons be grouped next to one another since they're conceptually similar? Assuming you meant the completed tasks filter, yes, I think that makes sense. Yes, that's what I meant ;-) Additional review https://git.eclipse.org/r/#/c/18451/ After playing around with this a bit, I think it makes more sense to keep that action available when in focused mode since it's like an even greater level of focus. I've amended Frank's review. A filter button has been added to the task list and the yellow person icon has been added to the tooltip. |